FFmpegImage: Implement Thumbnail extract (still wip cause of ARGB - which segfaults)

Author: fritsch

xbmc/guilib/FFmpegImage.cpp

@@ -101,12 +101,14 @@ CFFmpegImage::CFFmpegImage()
 {
   m_hasAlpha = false;
   m_pFrame = nullptr;
-
+  m_outputBuffer = nullptr;
 }
 
 CFFmpegImage::~CFFmpegImage()
 {
   av_frame_free(&m_pFrame);
+  // someone could have forgotten to call us
+  free(m_outputBuffer);
 }
 
 bool CFFmpegImage::LoadImageFromMemory(unsigned char* buffer, unsigned int bufSize,
@@ -243,7 +245,7 @@ bool CFFmpegImage::Decode(unsigned char * const pixels, unsigned int width, unsi
 
   bool needsCopy = false;
   int pixelsSize = pitch * height;
-  if (size == pixelsSize && pitch == pictureRGB->linesize[0])
+  if (size == pixelsSize && (int) pitch == pictureRGB->linesize[0])
   {
     // We can use the pixels buffer directly
     pictureRGB->data[0] = pixels;
@@ -309,9 +311,92 @@ bool CFFmpegImage::CreateThumbnailFromSurface(unsigned char* bufferin, unsigned
                                              unsigned char* &bufferout,
                                              unsigned int &bufferoutSize)
 {
-  return false;
+
+  if (format != XB_FMT_A8R8G8B8)
+  {
+    CLog::Log(LOGNOTICE, "Supplied format: %d is not supported.", format);
+  }
+  AVCodec* codec = avcodec_find_encoder(CODEC_ID_MJPEG);
+  if (!codec)
+    return false;
+
+  AVCodecContext* avOutctx = avcodec_alloc_context3(codec);
+  if (!avOutctx)
+    return false;
+
+  avOutctx->height = height;
+  avOutctx->width = width;
+  avOutctx->time_base.num = 1;
+  avOutctx->time_base.den = 1;
+  avOutctx->pix_fmt = PIX_FMT_YUVJ420P;
+
+  unsigned int internalBufOutSize = 0;
+
+  internalBufOutSize = avpicture_get_size(avOutctx->pix_fmt, avOutctx->width, avOutctx->height);
+  m_outputBuffer = (uint8_t*) av_malloc(internalBufOutSize);
+  if (!m_outputBuffer)
+  {
+    avcodec_free_context(&avOutctx);
+    return false;
+  }
+
+  if (avcodec_open2(avOutctx, codec, NULL) < 0 )
+  {
+    CLog::Log(LOGERROR, "Could not generate thumbnail: %s", destFile.c_str());
+    av_free(m_outputBuffer);
+    m_outputBuffer = NULL;
+    avcodec_free_context(&avOutctx);
+    return false;
+  }
+
+  AVFrame* frame = av_frame_alloc();
+  if (!frame)
+  {
+    CLog::Log(LOGERROR, "Could not generate thumbnail: %s", destFile.c_str());
+    av_free(m_outputBuffer);
+    m_outputBuffer = NULL;
+    avcodec_close(avOutctx);
+    avcodec_free_context(&avOutctx);
+    return false;
+  }
+
+  frame->pts = 1;
+  frame->quality = avOutctx->global_quality;
+  frame->data[0] = (uint8_t*) bufferin;
+  frame->height = height;
+  frame->width = width;
+  frame->linesize[0] = pitch;
+  frame->format = AV_PIX_FMT_ARGB;
+
+  int got_package = 0;
+  AVPacket avpkt;
+  av_init_packet(&avpkt);
+  avpkt.data = m_outputBuffer;
+  avpkt.size = internalBufOutSize;
+
+  if ((avcodec_encode_video2(avOutctx, &avpkt, frame, &got_package) < 0) || (got_package == 0))
+  {
+    CLog::Log(LOGERROR, "Could not generate thumbnail: %s", destFile.c_str());
+    av_free(m_outputBuffer);
+    m_outputBuffer = NULL;
+    av_frame_free(&frame);
+    avcodec_close(avOutctx);
+    avcodec_free_context(&avOutctx);
+    return false;
+  }
+
+  bufferoutSize = avpkt.size;
+  bufferout = m_outputBuffer;
+
+  av_frame_free(&frame);
+  avcodec_close(avOutctx);
+  avcodec_free_context(&avOutctx);
+
+  return true;
 }
 
 void CFFmpegImage::ReleaseThumbnailBuffer()
 {
+  av_free(m_outputBuffer);
+  m_outputBuffer = NULL;
 }

xbmc/guilib/FFmpegImage.h

@@ -53,4 +53,5 @@ class CFFmpegImage : public IImage
   static AVPixelFormat ConvertFormats(AVFrame* frame);
 
   AVFrame* m_pFrame;
+  uint8_t* m_outputBuffer;
 };