This repository was archived by the owner on Jan 19, 2023. It is now read-only.
Touchscreen support #13
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks a bunch for the contribution! Moving forward I hope to implement pinch to zoom, swiping between images, etc., but as that will probably involve adding an extra library as well as take a fair bit of time, so maybe implementing them one by one like this is the best strategy. I'm not too experienced in building off other people's pull requests, so I've used your commit in a branch of my own which I'll be merging soon. So I'll close this PR, but it is being used in #14 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue #6
Note that I've only tested this on chrome dev tools, so be sure to test it more. It's not the prettiest code and could use some refactoring, but I'm too lazy to do anything about it at the moment :)