Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start trace at center of connection point #3379

wants to merge 3 commits into
base: develop


Copy link

commented Dec 15, 2017

As per issue #3128 and #3316 traces did not always connect to the pad. This was made worse when using large traces.

It turns out the same math was being applied to the clipping in two places.
In clipablewire.cpp
GraphicsUtils::shortenLine(p1, p2, c1->calcClipRadius() + (m_pen.width() / 2.0), 0);
Which was sending the clipped data to shortenLine in connectoritem.cpp
return radius() - (strokeWidth() / 2.0);
It looks like (m_pen.width() / 2.0) does the same thing as (strokeWidth() / 2.0) causing the path to be too short.

This patch fixes the above issues but exacerbates this issue #3120 which is only an issue for using SVG or PDF for home etching when you want your drill to self center in the copper divot. The best solution would be to perform a difference of the copper and drill SVGs giving us round holes on export not trying to prevent it during routing.

Start trace at center of connection point
Allow traces to start in the center of rings and pads. Results in the ends of the traces overlapping hole in through hole parts.
zjedi approved these changes Jul 3, 2018

@ovidiub13 ovidiub13 changed the base branch from master to develop Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.