Added parts for FRC. Namely, RoboRio, PDP, VRM, PCM, AMT103, TalonSRX #141
Conversation
|
Thanks for making this contribution to the FRC community. I'd like to start using this right away. Is it possible for you to package it and submit it to the fritzing forum with the other parts? |
|
Sure - I'm not sure why the merge request wasn't approved. |
|
Hello and sorry for the delay! I will check the requests today and make the merge if anything is ok. |
|
thanks for this good work so far in breadboard-view. thank you
|
|
Hi! Thanks for the notes. These parts are actually not applicable for schematic / PCB - You can only get them packaged as the breadboard version shows. Is there a way to note that in the fritzing part? Thanks |
|
in this case i would suggest to make a footprint linke the pinout of the packaged board. like the arduino boards or the raspberry ... so people can use these footprint to design a pcb that can get attached to the packaged boards in real life. for schematic it's the same. look at the arduino boards. it's a "proper" sized rectangle with the pinout the board have. greetings |
|
I've edited the schematic and pcb for AMT103. Could you verify that the formats are correct before I move on to the bigger ones? By the way, is there a way to create the pcb / schematics automatically? It's over a hundred pins |
|
sooo i checked your new commit. first of all, yes you can do the schematic like this. the easiest would be a rectangle, but your approach is nice as well. there where issues:
because of the automatic creation. there is a tool to create all files from an "unproteced" eagle brd file... look at: when there is not brd file ... |
|
Hej. RRio
please fix, otherwise i cannot merge ... thanks |
|
Looks like those parts were never completed. Suggesting to close this PR. |
|
I actually never got around to finishing them. Is there a way to simple disable the PCB and Schematic? As you said - There's not much sense in both of them - Only in breadboard. The problem them is just that it's very tedious to add all pins one by one. Do you know any way to automate it? |
|
Eventually it might make sense to split this Pull Request, so that part that are already fine or easy to fix can be merged. |
|
I'm willing (and have time) to fix up the parts, except I can't find them. I managed to get something (but it is only the bin files, not the part files which is what I would need) via git fetch upstream pull/141/head:pr-141 if someone can tell me how to get at the parts themselves I'll try and fix them up. Peter |
KjellMorgenstern
force-pushed
the
frc-parts
branch
from
c149d2b
to
afd6306
Compare
|
I rebased the PR onto the 'develop' (not nightlyParts anymore) branch, maybe that helps.
Listing the files shows several .svg files and the following ones. bins/more/frc-mono.png |
|
Hi guys,
I have the source files if needed (Photoshop, Illustrator, and so on)
Thanks
Nitay
…On Wed, Jul 10, 2019 at 10:47 AM Kjell ***@***.***> wrote:
I rebased the PR onto the 'develop' (not nightlyParts anymore) branch,
maybe that helps.
git fetch origin pull/141/head:pr-141 #my remote is 'origin', not
'upstream'
Listing the files shows several .svg files and the following ones.
git diff --name-only pr-141 develop
bins/more/frc-mono.png
bins/more/frc.fzb
bins/more/frc.png
core/AMT103.fzp
core/PCM.fzp
core/PDP.fzp
core/RoboRio.fzp
core/TalonSRX.fzp
core/VRM.fzp
core/YumoE6B2.fzp
core/router.fzp
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#141?email_source=notifications&email_token=AAAEVNPA5GVQX3PQAJO2JXLP6WH2RA5CNFSM4EV36R7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZSTSJI#issuecomment-509950245>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAEVNN3USTIV7XR35YFIDDP6WH2RANCNFSM4EV36R7A>
.
|
|
Looks like there is something wrong (or something I am not doing correctly more probably) with my remote branch of frtizing-parts. I cloned fritzing-parts locally which gives me branch develop (when my remote gives me branch master) git clone https://github.com/fritzing/fritzing-parts.git then git fetch origin pull/141/head:pr-141 and git diff --name-only develop bins/more/frc-mono.png which shows the bins as well as the fzp and svg files which were missing last time. I'll make the fixes and then will probably be back to figure out what to do with them once I have them (maybe make a pull request of my own will be easiest, unless one of you know another way to do it). I'll poke at my remote repository and see if I can fix it up to work correctly, because I need it to be correct. Learning github is almost as bad as learning Fritzing parts making :-) . Peter |
|
I ended up having to delete my fork of Fritzing-parts and redo the fork to get my copy in sync with the master (I suspect something I did screwed it up so it could no longer sync as the suggested methods of syncing didn't work, it claimed to be identical to upline, but didn't have the develop branch, now it does). I'm currently making changes to the AMT103 part (mostly internal in nature and not user visible, but some are user visible) and I'd like to suggest an alternative schematic (although in some ways I like the current one other than its size). I think the easiest way to do this, if @Nitaym doesn't object, is for me to post the parts as I complete them in the Fritzing forum in parts help so anyone interested can download them, try them in Fritzing and suggest changes. Does anyone have an objection to this plan? Peter |
|
Hi Peter,
Thanks for taking the lead on this!
I most certainly don't object to post in the forum!
That being said, I do believe that in order to get FRC students working
with the parts the installation process should be as simple as possible -
Built in to the parts library.
So let's do both!
Would you like my assistance in pushing the parts back? I can sort out the
git issues for you. Git can be painful on the first couple of times.
Thanks
Nitay
…On Thu, Jul 11, 2019 at 5:31 AM vanepp ***@***.***> wrote:
I ended up having to delete my fork of Fritzing-parts and redo the fork to
get my copy in sync with the master (I suspect something I did screwed it
up so it could no longer sync as the suggested methods of syncing didn't
work, it claimed to be identical to upline, but didn't have the develop
branch, now it does). I'm currently making changes to the AMT103 part
(mostly internal in nature and not user visible, but some are user visible)
and I'd like to suggest an alternative schematic (although in some ways I
like the current one other than its size). I think the easiest way to do
this, if @Nitaym <https://github.com/Nitaym> doesn't object, is for me to
post the parts as I complete them in the Fritzing forum in parts help so
anyone interested can download them, try them in Fritzing and suggest
changes. Does anyone have an objection to this plan?
Peter
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#141?email_source=notifications&email_token=AAAEVNJICS2MVMJP3YE2EKLP62LP7A5CNFSM4EV36R7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZVJ5DA#issuecomment-510303884>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAEVNM4VMGGD2MGQG5KGOLP62LP7ANCNFSM4EV36R7A>
.
|
|
@Nitaym : Hopefully with the re forked copy of Fritzing-parts I will be OK. The last time I submitted a few parts something went wrong and it refused to make more pull requests. I suspect that is when my forked repository got screwed up. My intent is to submit the fixed up parts here to be added to core, the forum is just an easier place to post review versions to make sure you don't object to the changes I'm making. I completely agree that core parts is where this wants to be. I've just posted the first fixed up part (the AMT103 encoder) in this thread in the forums for review: http://forum.fritzing.org/t/frc-parts-for-review/7315 The new part has been run through my part checking python script and thus shouldn't have any problems getting approved. If you see changes you don't like post and I'll correct them. I'll start on the next part now. Peter |
|
OK, what I think are all the parts have been fixed up and posted to the referenced forum article. If you would have a look at them and see if there is anything wrong (the roboRIO and TalonSRX have the most changes) and check that these are all the parts, we should be ready to go. If they check out, it will probably be easiest to cancel this pull request and let me make one with the new parts or you can download the fzpz files and unpack them and modify this pull request. Note there are some unused (as far as I can see anyway) svg files in this pull request. Peter |
|
@Nitaym , @KjellMorgenstern I haven't forgotten this one, the corrected parts are all posted for review in the forum. If there isn't a hurry (which there may be with the start of a new school year soon) I'm inclined to wait til I finish the update to FritzingCheckPart.py to work with travis-ci to make sure all the parts pass all the tests (I think they will now, but a test of the final code is the best bet.) Thoughts? Peter |
|
FritzingCheckPart script improvements are welcome (I'd even rate them higher priority, the earlier we have it the easier it will be to avoid future part errors). But just because the script improvements are not finished we should not stop adding new parts. All the parts so far have been added without this script in travis-ci... |
|
OK, I'll make a new pull request with the fixed parts, as I think the script is going to take some time. I'm thinking it needs a proper test suite that trips all the error conditions (and I suspect some of them wont be able to occur because xml parsing may have failed before it gets that far) and that is likely to take a long time. I should have a new pull request with the fixed parts together in a day or two I expect. I need to verify the bin files are still ok and convert from fzpz format to core (one of the things I want to add to the script.) as the parts are all in fzpz format for the forum at present. Peter |
|
I am closing this pull request because it has been replaced with PR #214 |
Added parts for First Robotics Competition.
Namely:
I did not complete PCBs as they are not relevant for these parts