New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xmltream.py: avoid using SSLv3 on unsupported systems. #470

Open
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
1 participant
@biergaizi
Contributor

biergaizi commented Oct 4, 2017

For many modern systems, SSLv3 have been completely removed by
upstream providers. In this case, the system openssl doesn't
support SSLv3, hence ssl.PROTOCOL_SSLv3 is no longer a valid
attribute anymore.

This commit checks whether the system supports SSLv3, avoid
trying to call "ssl.PROTOCOL_SSLv3" if unsupported. A user-friendly
notice is also written to the log, the documentation have been
updated as well.

Signed-off-by: Yifeng Li tomli@tomli.me

xmltream.py: avoid using SSLv3 on unsupported systems.
For many modern	systems, SSLv3 have been completely removed by
upstream providers. In this case, the system openssl doesn't
support	SSLv3, hence ssl.PROTOCOL_SSLv3	is no longer a valid
attribute anymore.

This commit checks whether the system supports SSLv3, avoid
trying to call "ssl.PROTOCOL_SSLv3" if unsupported. A user-friendly
notice is also written to the log, the documentation have been
updated as well.

Signed-off-by: Yifeng Li <tomli@tomli.me>
@biergaizi

This comment has been minimized.

Show comment
Hide comment
@biergaizi

biergaizi Oct 4, 2017

Contributor

This should be included into stable versions as well.

Contributor

biergaizi commented Oct 4, 2017

This should be included into stable versions as well.

thusser pushed a commit to thusser/SleekXMPP that referenced this pull request Nov 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment