New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listeners should return percent complete if possible #113

Closed
frizbog opened this Issue Jul 11, 2016 · 2 comments

Comments

Projects
None yet
1 participant
@frizbog
Owner

frizbog commented Jul 11, 2016

If it's possible to do so, the Listeners for parsing, construction, and file operations should return percent complete numbers.

@frizbog frizbog added the enhancement label Jul 11, 2016

@frizbog frizbog added this to the Release 3 milestone Jul 11, 2016

@frizbog frizbog self-assigned this Jul 11, 2016

@frizbog

This comment has been minimized.

Owner

frizbog commented Jul 12, 2016

Started this on v3-development branch. Will not include percents because the size of the file may not be known if it's a stream without a file. I have modified it to include the number of bytes processed along with the number of lines. For a file, calling code would be able to determine the size of the file and calculate percents if desired based on the bytes processed in the FileProgressEvent classe compared to the file size...and for streams, knowing both the number of lines and the number of bytes processed might be useful...somehow.

@frizbog

This comment has been minimized.

Owner

frizbog commented Jul 16, 2016

Released in v3.0.0

@frizbog frizbog closed this Jul 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment