Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
A few of the JUnit tests fail to run on Windows platform #126
Here are the failing tests that seem to be Windows-related, with some failure results:
That is, the 7 failures are 2 hard-coded string tests with embedded line delimiters (the first and last), and 5 character encoding tests all in a single JUnit test class (separated by method name). I didn't dig into the 5, which are all strictly bytesWritten differences (all line counts etc are correct).
FYI, I've worked around these locally. In the Encoding tests:
and then in the bytesWritten assert, something like (this one for bigEndianUnicode):
for the String hard-codes compared with file Writer output, e.g. Issue97Test:
I've corrected things so they work on Mac and Windows.
To do so, I did have to introduce a new property on GedcomWriter that lets you set the style of line terminator you want (and passes it through to GedcomFileWriter which already had a property for this, but it wasn't exposed to callers). This backward-compatible API change is going to require changing the version number to 3.1.0.