New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up cut-and-pasted code #132

Closed
frizbog opened this Issue Aug 27, 2016 · 3 comments

Comments

Projects
None yet
1 participant
@frizbog
Owner

frizbog commented Aug 27, 2016

There is a lot of repeated (cut-and-pasted) code that should be pulled out into methods.

@frizbog frizbog added the quality label Aug 27, 2016

@frizbog frizbog self-assigned this Aug 28, 2016

frizbog added a commit that referenced this issue Aug 28, 2016

frizbog added a commit that referenced this issue Aug 28, 2016

frizbog added a commit that referenced this issue Aug 28, 2016

frizbog added a commit that referenced this issue Aug 28, 2016

frizbog added a commit that referenced this issue Aug 29, 2016

@frizbog

This comment has been minimized.

Owner

frizbog commented Aug 29, 2016

There is still some remaining code but because of Java's single-inheritance model the repetition is not worth removing.

@frizbog

This comment has been minimized.

Owner

frizbog commented Aug 29, 2016

v3.2.0-SNAPSHOT 2016-08-28T22:12:35-04:00

@frizbog

This comment has been minimized.

Owner

frizbog commented Sep 4, 2016

v3.2.0

@frizbog frizbog closed this Sep 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment