New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many custom tags don't load or write #167

Closed
frizbog opened this Issue Oct 2, 2016 · 3 comments

Comments

Projects
None yet
1 participant
@frizbog
Owner

frizbog commented Oct 2, 2016

There are a number of places where custom tags are not loaded into the model by the Parser and other places where custom tags in the model are not properly emitted in from the Writer.

Most notably, these include tags that have cross references to other nodes....the model holds direct references to these other nodes in most cases, which leaves nothing to hold custom tags about the reference. This was recently addressed in issue #161 for Individuals in a family but the problem is broader.

@frizbog frizbog added this to the Release 4.0.0 milestone Oct 2, 2016

@frizbog frizbog self-assigned this Oct 3, 2016

frizbog added a commit that referenced this issue Oct 3, 2016

frizbog added a commit that referenced this issue Oct 3, 2016

frizbog added a commit that referenced this issue Oct 3, 2016

@frizbog

This comment has been minimized.

Owner

frizbog commented Oct 3, 2016

Another example where this occurs is around enumerated values like SupportedVersion or AdoptedByWhichParent. Enums, being static, cannot hold state in a threadsafe manner, so these structures are going to need to change if they are to hold custom tag values.

@frizbog

This comment has been minimized.

Owner

frizbog commented Oct 3, 2016

See issue #168

frizbog added a commit that referenced this issue Oct 5, 2016

frizbog added a commit that referenced this issue Oct 5, 2016

frizbog added a commit that referenced this issue Oct 6, 2016

Making good progress on Issue #167.
Had to create MultiStringWithCustomFacts class so Lists of Strings could
also have custom facts attached.

frizbog added a commit that referenced this issue Oct 6, 2016

frizbog added a commit that referenced this issue Oct 7, 2016

frizbog added a commit that referenced this issue Oct 8, 2016

frizbog added a commit that referenced this issue Oct 8, 2016

frizbog added a commit that referenced this issue Oct 8, 2016

frizbog added a commit that referenced this issue Oct 8, 2016

@frizbog

This comment has been minimized.

Owner

frizbog commented Oct 8, 2016

I think I can basically call this one done, and open up new issues for anything new I discover or that gets reported.

@frizbog frizbog closed this Oct 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment