New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break up GedcomParser #85

Closed
frizbog opened this Issue Sep 27, 2015 · 3 comments

Comments

Projects
None yet
1 participant
@frizbog
Owner

frizbog commented Sep 27, 2015

GedcomParser is a magic class, with too much in it. A better way to deal with this would probably be a whole package of classes centered around parsing tags, and have GedcomParser orchestrate that activity, rather than doing it all itself.

Visitor pattern may apply nicely here.

@frizbog frizbog added the enhancement label Sep 27, 2015

@frizbog frizbog added this to the Release 3 milestone Sep 27, 2015

@frizbog frizbog self-assigned this Jul 7, 2016

@frizbog

This comment has been minimized.

Owner

frizbog commented Jul 7, 2016

I've started work on this.

frizbog added a commit that referenced this issue Jul 8, 2016

frizbog added a commit that referenced this issue Jul 8, 2016

frizbog added a commit that referenced this issue Jul 8, 2016

@frizbog

This comment has been minimized.

Owner

frizbog commented Jul 9, 2016

This is complete in the v3-development branch.

@frizbog

This comment has been minimized.

Owner

frizbog commented Jul 16, 2016

Released in v3.0.0

@frizbog frizbog closed this Jul 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment