Skip to content

feat: add workflow for retrieving GitHub App metadata#6

Merged
marcusrbrown merged 8 commits into
mainfrom
feat/add-github-app-workflow
Jun 28, 2023
Merged

feat: add workflow for retrieving GitHub App metadata#6
marcusrbrown merged 8 commits into
mainfrom
feat/add-github-app-workflow

Conversation

@marcusrbrown
Copy link
Copy Markdown
Collaborator

No description provided.

@marcusrbrown marcusrbrown self-assigned this Jun 28, 2023
@marcusrbrown marcusrbrown merged commit aaf93cb into main Jun 28, 2023
@marcusrbrown marcusrbrown deleted the feat/add-github-app-workflow branch June 28, 2023 11:09
marcusrbrown added a commit that referenced this pull request Apr 17, 2026
…rrence

Updates docs/solutions/runtime-errors/octokit-invitation-method-names-2026-04-17.md
based on today's PR #3087 findings.

Additions:
- Second occurrence section: starRepo → starRepoForAuthenticatedUser
  (same class of hallucinated-method bug as the original listRepositoryInvitations
  / acceptInvitation fix in PR #3083, now in a different namespace)
- Nullability drift finding: handwritten interfaces also silently tighten null
  variants. RepositoryInvitation.inviter was typed non-null but GitHub's real
  schema is nullable-simple-user. Guarded skip with reason 'inviter-unknown'.
- Two new prevention rules:
  - #5: replace handwritten interfaces with derived types via
    Pick<InstanceType<typeof Octokit>['rest'], ...> — hallucinated methods
    and dropped nulls both become tsc errors
  - #6: after first hallucinated-method hit, audit every SDK call site

Frontmatter: added category, last_updated, broadened title and tags
(type-safety, handwritten-interface).
marcusrbrown added a commit that referenced this pull request Apr 17, 2026
…rrence (#3093)

Updates docs/solutions/runtime-errors/octokit-invitation-method-names-2026-04-17.md
based on today's PR #3087 findings.

Additions:
- Second occurrence section: starRepo → starRepoForAuthenticatedUser
  (same class of hallucinated-method bug as the original listRepositoryInvitations
  / acceptInvitation fix in PR #3083, now in a different namespace)
- Nullability drift finding: handwritten interfaces also silently tighten null
  variants. RepositoryInvitation.inviter was typed non-null but GitHub's real
  schema is nullable-simple-user. Guarded skip with reason 'inviter-unknown'.
- Two new prevention rules:
  - #5: replace handwritten interfaces with derived types via
    Pick<InstanceType<typeof Octokit>['rest'], ...> — hallucinated methods
    and dropped nulls both become tsc errors
  - #6: after first hallucinated-method hit, audit every SDK call site

Frontmatter: added category, last_updated, broadened title and tags
(type-safety, handwritten-interface).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant