Cleaned up instance variable warnings #17

Merged
merged 1 commit into from Feb 27, 2013

Projects

None yet

2 participants

@rmm5t
Collaborator
rmm5t commented Feb 27, 2013

Since warnings were turned on in the test suite, I figured you might want them eliminated too.

@frodsan frodsan merged commit b353bb1 into frodsan:master Feb 27, 2013

1 check passed

default The Travis build passed
Details
@frodsan
Owner
frodsan commented Feb 27, 2013

Thanks! ❤️ I knew about this situation, Im planning to extract all the ActiveModel Validations matchers to https://github.com/frodsan/minitest-activemodel and just make a dependency to it.

@rmm5t
Collaborator
rmm5t commented Feb 27, 2013

Cool. Let me know if you need some help on the extraction.

Ryan McGeary

On Wednesday, February 27, 2013 at 1:01 AM, Francesco Rodríguez wrote:

Thanks! I knew about this situation, Im planning to extract all the ActiveModel Validations matchers to https://github.com/frodsan/minitest-activemodel and just make a dependency to it.


Reply to this email directly or view it on GitHub (#17 (comment)).

@frodsan
Owner
frodsan commented Feb 27, 2013

Any help is welcome 😄, I'm not currently using mongoid in my projects, do you want me to add you as a mantainer? ❤️

@rmm5t
Collaborator
rmm5t commented Feb 27, 2013

I'd be happy to be maintainer. Also, my rubygems email address is the same as listed on my github profile.

On Wednesday, February 27, 2013 at 1:08 AM, Francesco Rodríguez wrote:

Any help is welcome , I'm not currently using mongoid in my projects, do you want me to add you as a mantainer?


Reply to this email directly or view it on GitHub (#17 (comment)).

@frodsan
Owner
frodsan commented Feb 27, 2013

Hey! I added you ❤️ Thanks! I bootstrap some code for the extraction (https://github.com/frodsan/mongoid-minitest/tree/minitest_activemodel) ... I will add you to this repo https://github.com/frodsan/minitest-activemodel too. I put some issues about what is missing to complete the extraction. When we complete, I will release 1.0 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment