Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OCaml version #31

Merged
merged 2 commits into from May 15, 2018
Merged

Added OCaml version #31

merged 2 commits into from May 15, 2018

Conversation

314eter
Copy link
Contributor

@314eter 314eter commented May 15, 2018

No description provided.

right = None
}

let rec has_value tree value =
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation does not match all the other implementation. Such benchmark is unfair.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I didn't make it the main version, but I didn't realize the benchmark algorithm is that much slower.

@314eter
Copy link
Contributor Author

314eter commented May 15, 2018

The immutable version is comparable to the Haskell implementation. It's slower, but safer and more idiomatic.

@frol
Copy link
Owner

frol commented May 15, 2018

Thank you!

@frol frol merged commit a3b2f62 into frol:master May 15, 2018
@frol
Copy link
Owner

frol commented May 16, 2018

I have just updated the scoreboards!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants