New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build doesn't work in the typescript version #2

Closed
umstek opened this Issue Jan 8, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@umstek
Copy link
Contributor

umstek commented Jan 8, 2019

Problem:
The line:

"build": "react-scripts build && ts-node -O {\\\"module\\\":\\\"commonjs\\\"} node_modules/.bin/navi-scripts build",

tries to run a shell/cmd with node-ts instead of the actual navi-scripts.js itself.

Solution:
Replacing the line with "build": "react-scripts build && ts-node -O {\\\"module\\\":\\\"commonjs\\\"} node_modules/navi-scripts/bin/navi-scripts.js build", fixes the problem.

@jamesknelson

This comment has been minimized.

Copy link
Contributor

jamesknelson commented Jan 8, 2019

Could you let me know what platform you're using? This works fine for me on Mac OS 10.14, but perhaps the .bin directory is mac specific?

@umstek

This comment has been minimized.

Copy link
Contributor

umstek commented Jan 8, 2019

I'm using Windows. Didn't try on Linux yet.
No, the bin directory exists; but the navi-scripts file there is a shell script (and cmd).

jamesknelson added a commit that referenced this issue Jan 9, 2019

@jamesknelson

This comment has been minimized.

Copy link
Contributor

jamesknelson commented Jan 9, 2019

I see, things seem to work differently on mac and windows. Thanks for submitting the fix! I've just merged it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment