Add ARIA accessibility #63

Merged
merged 2 commits into from Dec 17, 2013

Projects

None yet

3 participants

@myfreeweb
Contributor

Tested with VoiceOver on OS X and iOS. 👍

@fronteed
Owner

Well done 👍

I think this should be an option.
Can you please update the code?
It should add ARIA attributes when aria option is ON (should be OFF by default).

@myfreeweb
Contributor

Why do you think so?
There's no reason anyone would want to disable this.
ARIA never causes any problems.
The option would just add more bytes for no good reason.

On Aug 19, 2013, at 4:57 PM, Damir notifications@github.com wrote:

Well done 👍

I think this should be an option.
Can you please update the code?
It should add ARIA attributes when aria option is ON (should be OFF by default).


Reply to this email directly or view it on GitHub.

@fronteed
Owner

It should be an option because of the performance reasons.

When iCheck is used on the admin pages and there're many checkboxes, aria option may slow down the overall performance. Since admin pages are closed for regular users, ARIA support may not be needed.

@fronteed fronteed merged commit 66933fc into fronteed:master Dec 17, 2013
@skarkkai
skarkkai commented Dec 1, 2016

I would encourage you to enable ARIA support by default. People typically don't change default config unless necessary, due to time constraints and laziness. Finland's biggest newspaper just started using iCheck for their online polls, and they obviously haven't enabled ARIA support because the polls are completely unusable with a screen reader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment