Fix public path of static assets

[luisherranz]

What:

Fix the public path of the assets (images, fonts, css...).

Why:

After the switch to dynamic public paths (#890), they public path of the static assets was not working correctly anymore.

How:

It seems like changing the dynamic public path (__webpack_public_path__) at request time is not possible, so I'm just doing a string replace in the SSRed HTML.

Tasks:

• Code
• End to end tests
• Add a changeset (with link to its Feature Discussion if it exists)
• Update community discussions (this)

Unrelated Tasks

• TSDocs
• TypeScript
• Unit tests
• TypeScript tests
• Update starter themes
• Update other packages

Additional Comments

[changeset-bot]

🦋 Changeset detected

Latest commit: adeee80

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[luisherranz]

I've fixed an unrelated problem with the Google Ad Manager E2E tests.

[luisherranz]

[AsadZahed]

@luisherranz i updated the frontity code same as you did it in pull request but some of the images have appeared, most of them are still missing. The path on missing images is written as attached in below picture:

I updated these files:

• Public-path.ts
• server-side-rendering.ts
• index.ts

[luisherranz]

Thanks, @AsadZahed. My mistake, it should be a global replace. I'll fix it right away 🙂

[SantosGuillamot]

LGTM 🙂

[luisherranz]

Thanks Mario.

[AsadZahed]

HI @luisherranz Thanks for the update, i just moved to new version but the font has still issues on reload of the page. I will be thankful if you look into it.

[luisherranz]

Would you mind opening a new issue with information about the problem?

[orballo]

Looks good to me :)
EDIT: Too late xD

[luisherranz]

Setting the public path to __webpack_public_path__ in the server may not work in all cases: #913