From 029608bae4a34fe1660b0d79f2414ba9bab0534b Mon Sep 17 00:00:00 2001 From: hyochan Date: Sun, 15 Jul 2018 16:26:05 +0900 Subject: [PATCH 1/2] Better setup for android build version. React Native now has its project set up with default build version of androids sdk. Set android build version to that ofrootProjet``s to prevent from build failing cause of version mismatch. --- templates/android.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/templates/android.js b/templates/android.js index 8fa18aa..8062ff9 100644 --- a/templates/android.js +++ b/templates/android.js @@ -17,12 +17,12 @@ apply plugin: 'com.android.library' apply plugin: 'maven' android { - compileSdkVersion 23 - buildToolsVersion "23.0.1" + compileSdkVersion rootProject.ext.compileSdkVersion + buildToolsVersion rootProject.ext.buildToolsVersion defaultConfig { - minSdkVersion 16 - targetSdkVersion 22 + minSdkVersion rootProject.ext.minSdkVersion + targetSdkVersion rootProject.ext.targetSdkVersion versionCode 1 versionName "1.0" } From 42d58f0f703c25883a6394cceae6c099ca383d65 Mon Sep 17 00:00:00 2001 From: Hyo Chan Jang Date: Fri, 24 Aug 2018 18:00:34 +0900 Subject: [PATCH 2/2] Safer build config for android. Support older react-native version. --- templates/android.js | 29 +++++++++++++++++------------ 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/templates/android.js b/templates/android.js index 8062ff9..325592b 100644 --- a/templates/android.js +++ b/templates/android.js @@ -16,19 +16,24 @@ buildscript { apply plugin: 'com.android.library' apply plugin: 'maven' +def DEFAULT_COMPILE_SDK_VERSION = 27 +def DEFAULT_BUILD_TOOLS_VERSION = "27.0.3" +def DEFAULT_MIN_SDK_VERSION = 16 +def DEFAULT_TARGET_SDK_VERSION = 26 + android { - compileSdkVersion rootProject.ext.compileSdkVersion - buildToolsVersion rootProject.ext.buildToolsVersion - - defaultConfig { - minSdkVersion rootProject.ext.minSdkVersion - targetSdkVersion rootProject.ext.targetSdkVersion - versionCode 1 - versionName "1.0" - } - lintOptions { - abortOnError false - } + compileSdkVersion rootProject.ext.hasProperty('compileSdkVersion') ? rootProject.ext.compileSdkVersion : DEFAULT_COMPILE_SDK_VERSION + buildToolsVersion rootProject.ext.hasProperty('buildToolsVersion') ? rootProject.ext.buildToolsVersion : DEFAULT_BUILD_TOOLS_VERSION + + defaultConfig { + minSdkVersion rootProject.ext.hasProperty('minSdkVersion') ? rootProject.ext.minSdkVersion : DEFAULT_MIN_SDK_VERSION + targetSdkVersion rootProject.ext.hasProperty('targetSdkVersion') ? rootProject.ext.targetSdkVersion : DEFAULT_TARGET_SDK_VERSION + versionCode 1 + versionName "1.0" + } + lintOptions { + abortOnError false + } } repositories {