Skip to content

Conversation

@maicki
Copy link
Contributor

@maicki maicki commented Aug 25, 2018

Let's update the default React Native version for a library to a later version as 0.44 as it's currently is. Another way would be to let the user define the React Native version while creating the library. There would be a problem though as the React Native version need to have a specific React version.

@maicki maicki requested a review from thorbenprimke August 25, 2018 11:47
Copy link
Collaborator

@thorbenprimke thorbenprimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could also have a few predefined options. Then with each new version coming out, it becomes the default one but the others could still be used via options (since we would have a map between react and react-native verisons).

Copy link
Collaborator

@thorbenprimke thorbenprimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meant to ✅

@maicki maicki merged commit 916fe47 into frostney:master Sep 16, 2018
@maicki maicki mentioned this pull request Sep 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants