From 1e993f8ae7c2fa8645b5f877a205df5345d07929 Mon Sep 17 00:00:00 2001 From: Alden Torres Date: Sat, 13 Feb 2016 10:13:28 -0500 Subject: [PATCH] What an ugly name for a public API (COMPARATOR) --- src/main/java/com/frostwire/jlibtorrent/Address.java | 11 +---------- .../java/com/frostwire/jlibtorrent/DHTSettings.java | 4 ++-- src/main/java/com/frostwire/jlibtorrent/Sha1Hash.java | 11 +++-------- 3 files changed, 6 insertions(+), 20 deletions(-) diff --git a/src/main/java/com/frostwire/jlibtorrent/Address.java b/src/main/java/com/frostwire/jlibtorrent/Address.java index 185e39363..267b05f72 100644 --- a/src/main/java/com/frostwire/jlibtorrent/Address.java +++ b/src/main/java/com/frostwire/jlibtorrent/Address.java @@ -2,8 +2,6 @@ import com.frostwire.jlibtorrent.swig.address; -import java.util.Comparator; - /** * @author gubatron * @author aldenml @@ -26,13 +24,6 @@ public String toString() { } public static int compare(Address a1, Address a2) { - return COMPARATOR.compare(a1, a2); + return address.compare(a1.addr, a2.addr); } - - public static final Comparator
COMPARATOR = new Comparator
() { - @Override - public int compare(Address o1, Address o2) { - return address.compare(o1.addr, o2.addr); - } - }; } diff --git a/src/main/java/com/frostwire/jlibtorrent/DHTSettings.java b/src/main/java/com/frostwire/jlibtorrent/DHTSettings.java index 996fe12cd..c9e88c013 100644 --- a/src/main/java/com/frostwire/jlibtorrent/DHTSettings.java +++ b/src/main/java/com/frostwire/jlibtorrent/DHTSettings.java @@ -98,7 +98,7 @@ public void setMaxFailCount(int value) { * * @return */ - public int getMaxTorrents() { + public int maxTorrents() { return s.getMax_torrents(); } @@ -109,7 +109,7 @@ public int getMaxTorrents() { * * @param value */ - public void setMaxTorrents(int value) { + public void maxTorrents(int value) { s.setMax_torrents(value); } diff --git a/src/main/java/com/frostwire/jlibtorrent/Sha1Hash.java b/src/main/java/com/frostwire/jlibtorrent/Sha1Hash.java index b8b954111..fe3b4643b 100644 --- a/src/main/java/com/frostwire/jlibtorrent/Sha1Hash.java +++ b/src/main/java/com/frostwire/jlibtorrent/Sha1Hash.java @@ -2,8 +2,6 @@ import com.frostwire.jlibtorrent.swig.sha1_hash; -import java.util.Comparator; - /** * This type holds a SHA-1 digest or any other kind of 20 byte * sequence. It implements a number of convenience functions, such @@ -110,10 +108,7 @@ public static Sha1Hash min() { return new Sha1Hash(sha1_hash.min()); } - public static final Comparator COMPARATOR = new Comparator() { - @Override - public int compare(Sha1Hash o1, Sha1Hash o2) { - return sha1_hash.compare(o1.h, o2.h); - } - }; + public static int compare(Sha1Hash h1, Sha1Hash h2) { + return sha1_hash.compare(h1.h, h2.h); + } }