New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XXE in UpdateMessageReader.java via Man-in-the-Middle (MitM) #829
Comments
|
I don't see this being a issue. There is no login for the frostwire site, but you could steal there cookies. |
|
the issue is a man in the middle attack, where somehow they could serve malicious XML and have FrostWire parse a malicious update URL. But I believe this shouldn't be the case as now the update URL is HTTPS based |
|
I also believe in recent updates we changed the XMLReader with the one recommended for JDK12, perhaps the new one |
|
@gubatron if the update URL is HTTPS base, will this issue still exist? |
|
I think it's significantly harder, but then again, we changed the XML Reader class for a new one that comes with Java 12. I'm gonna go ahead and close this. |
The Issue
An XML External Entity attack is a type of attack against an application that parses XML input. This attack occurs when XML input containing a reference to an external entity is processed by a weakly configured XML parser. This attack may lead to the disclosure of confidential data, denial of service, server side request forgery, port scanning from the perspective of the machine where the parser is located, and other system impacts.
Where the Issue Occurred
The following code snippets display the usage of
XMLReaderwithout securely disabling entities:frostwire/desktop/src/com/frostwire/gui/updates/UpdateMessageReader.java
Line 306 in 7414e3b
An attacker can Man-in-the-Middle (MitM) the HTTP call to the URL below:
frostwire/desktop/src/com/frostwire/gui/updates/UpdateMessageReader.java
Line 43 in 7414e3b
Remediation
https://www.owasp.org/index.php/XML_External_Entity_(XXE)_Prevention_Cheat_Sheet
The text was updated successfully, but these errors were encountered: