Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not automatically assume 'sudo' #17

Closed
xsuchy opened this issue Oct 16, 2014 · 2 comments
Closed

Do not automatically assume 'sudo' #17

xsuchy opened this issue Oct 16, 2014 · 2 comments
Labels

Comments

@xsuchy
Copy link
Contributor

xsuchy commented Oct 16, 2014

I got after upgrade:

  * Some applications using:
      sudo kdeinit4
      sudo akonadictl restart
      sudo dropbox stop; dropbox start

This is incorrect. This must be run as user who owns that process. I would suggest to change it to:

  * User "mirek" can restart some application using:
      kdeinit4
      akonadictl restart
      dropbox stop; dropbox start
@FrostyX FrostyX added the bug label Oct 16, 2014
@FrostyX
Copy link
Owner

FrostyX commented Oct 16, 2014

Thanks for the report,
you are definietely right. I am adding sudo after this condition

if os.getlogin() != "root":

which is not sufficient. It should be

if you are not root and application is daemon

in that case all applications restartable with service foo restart will be printed with sudo, but other commands like kdeinit4, akonadictl restart, etc witout it. Am I right?

@xsuchy
Copy link
Contributor Author

xsuchy commented Oct 16, 2014

Yes, I think we can make this assumption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants