New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"pip install pillow" is required even without "-s" option #23

Closed
Tiryoh opened this Issue Dec 17, 2017 · 2 comments

Comments

2 participants
@Tiryoh
Contributor

Tiryoh commented Dec 17, 2017

I got an error like this on version abc070e.

$ ./splatnet2statink.py -r -M 1200
Traceback (most recent call last):
  File "./splatnet2statink.py", line 11, in <module>
    from PIL import Image, ImageDraw
ImportError: No module named PIL

pip install pillow solved this problem, so I assume that pip install pillow is required.

@frozenpandaman

This comment has been minimized.

Owner

frozenpandaman commented Dec 17, 2017

Oh lol I'm dumb. Thanks @Tiryoh. :)

PIL/Pillow is only used with the -s flag so as of dffc9a0 I've conditionally imported it. Now this probably isn't good Python style (but hey, it is allowed – if someone thinks of a better solution let me know) but I'd really like to not force users to install it if they don't need it… and it's only needed in a case that I don't think most people use. (2 dependencies to install by hand is OK, but 3 is getting to the point where it'd probably be better to have a requirements.txt…)

P.S. You can uninstall it now if you want. 😉

@Tiryoh

This comment has been minimized.

Contributor

Tiryoh commented Dec 18, 2017

@frozenpandaman
I got it. Thanks for your support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment