Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Files::flush(true) #25

Merged
merged 1 commit into from
Nov 16, 2016
Merged

Fix: Files::flush(true) #25

merged 1 commit into from
Nov 16, 2016

Conversation

alexpica
Copy link
Contributor

@alexpica alexpica commented Nov 15, 2016 •
edited by frqnck

What did you implement:

Fixing an issue where the Files::flush method does not work when called with true.
Also added test for it.

Done and todos:

  • Write unit tests,
  • Make sure code coverage hasn't dropped,
  • Leave a comment that this is ready for review once you've finished the implementation.

@coveralls
Copy link

coveralls commented Nov 15, 2016 •
edited

Coverage Status

Changes Unknown when pulling 5d34e08 on alexpica:master into * on frqnck:master*.

@frqnck frqnck changed the title Fix: Files::flush(true) does not work Fix: Files::flush(true) Nov 16, 2016
@frqnck frqnck added the bug label Nov 16, 2016
@frqnck frqnck merged commit 1cac3e5 into apix:master Nov 16, 2016
@frqnck
Copy link
Member

frqnck commented Nov 16, 2016

@alexpica thank you for the contribution! 👍

@alexpica
Copy link
Contributor Author

@frqnck My pleasure. Thank you for the nice library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexpica @coveralls @frqnck