You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is more of a nit to how we do this in GO, I think these gets rerendered every time we change an artifact/relic, but it should rerender every time an artifact/relic is added/removed (since it only display the total).
It make sense to use the DataManagerCallback.reason string, and check against 'remove' | 'new'. Would also make sense to store total as a state instead of useForceUpdate, so when total is set as the same value again, it doesnt trigger a revalue.
This is more of a nit to how we do this in GO, I think these gets rerendered every time we change an artifact/relic, but it should rerender every time an artifact/relic is added/removed (since it only display the total).
It make sense to use the
DataManagerCallback.reason
string, and check against'remove' | 'new'
. Would also make sense to storetotal
as a state instead ofuseForceUpdate
, so when total is set as the same value again, it doesnt trigger a revalue.Originally posted by @frzyc in #2025 (comment)
Psudocode:
Example implementation #2061
The text was updated successfully, but these errors were encountered: