Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown globbing input #2073

Closed
giacomociti opened this Issue Aug 28, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@giacomociti
Copy link

giacomociti commented Aug 28, 2018

while migrating to FAKE 5 I got this error message:

 (Unknown globbing input '\**\bin\Debug\*.Tests.dll', try to use a relative path and report an issue!)

Following the message I solved the issue (using the relative path .\**\bin\Debug\*.Tests.dll) and now I'm reporting it:)

Thanks

@matthid

This comment has been minimized.

Copy link
Collaborator

matthid commented Aug 28, 2018

So this was working before and behaving like your relative path, correct?

@giacomociti

This comment has been minimized.

Copy link
Author

giacomociti commented Aug 28, 2018

yes, with FAKE 4.64.13 it was behaving like a relative path even if the starting dot was missing.
Also notice that the original expression was

 !! "/**/bin/Debug/*.Tests.dll"

so in the error message the slashes are reversed (of course I'm running on Windows 10)

@matthid

This comment has been minimized.

Copy link
Collaborator

matthid commented Sep 3, 2018

Ok I guess the error message and behavior is reasonable. We should change the message in that particular situation (where we detect starting / or \) and remove the "report an issue".

Just to explain starting with / is considered an absolute path on unix system, therefore I feel like we shouldn't "just" make that a relative path on windows.

I added the message while rewriting some parts of the globbing implementation where I wasn't sure how and when a particular code path can be reached

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.