Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IgnoreTestCase #1159

Merged
merged 2 commits into from Mar 3, 2016
Merged

Fix IgnoreTestCase #1159

merged 2 commits into from Mar 3, 2016

Conversation

laedit
Copy link
Contributor

@laedit laedit commented Mar 2, 2016

use the Ignored param as stated in AppVeyor docs: http://www.appveyor.com/docs/build-worker-api#update-tests

@forki
Copy link
Member

forki commented Mar 2, 2016

what about the message param?

@laedit
Copy link
Contributor Author

laedit commented Mar 2, 2016

It wasn't used and have no proper usage in the AppVeyor docs so I assumed that it wasn't necessary.

@forki
Copy link
Member

forki commented Mar 2, 2016

yes but this now broke the signature of the function. Which is probably OK in this case, but it also broke the build.

@laedit
Copy link
Contributor Author

laedit commented Mar 2, 2016

Sorry, I was too quick.

If you are ok with the suppression of the message param I will fix the build, otherwise I will restore it.

@forki
Copy link
Member

forki commented Mar 2, 2016

I suggest you add it again. even if it doesn't do anything useful.

@laedit
Copy link
Contributor Author

laedit commented Mar 2, 2016

Done, sorry for the disturbance.

forki added a commit that referenced this pull request Mar 3, 2016
@forki forki merged commit 28f0210 into fsprojects:master Mar 3, 2016
@forki
Copy link
Member

forki commented Mar 3, 2016

thx

@laedit laedit deleted the patch-1 branch March 3, 2016 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants