Use UTF-8 encoding for process output on Mono #1212
Conversation
Fixes encoding issus on systems when encoding property is not set.
|
Quite possibly :) If it is, then we have the same bug in Xamarin Studio somewhere :) |
|
Release in progress. Would love to hear if you can still reproduce Chinese Quite possibly :) If it is, then we have the same bug in Xamarin Studio — Reply to this email directly or view it on GitHub |
|
Haven't seen it once since the chat in gitter the other day. On Sun, Apr 10, 2016 at 6:26 PM, Steffen Forkmann notifications@github.com
|
|
I'll give it a spin when I start work and let you know 👍 |
|
Looks like it broke others: #1213 Should I revert? |
|
Ok I reverted. @juergenhoetzel I think the idea is good, but it seems we need to be more careful where to enable this. /cc @kentcb |
Fixes encoding issues when encoding property is not set: Refs fsprojects#1212. This is a revised version of commit 2d63a45, which broke external processes when standard error/output is not redirected: Refs fsprojects#1213 This commit only sets the encoding when output is redirected.
|
Can I ask if you are getting it on osx only, or if it's on linux too @juergenhoetzel ? |
|
@Yantrio I use Arch Linux only (Mono 4.4.0.40 currently) |
See fsprojects/FAKE#1196, fsprojects/FAKE#1212, fsprojects/FAKE#1213 & fsprojects/FAKE#1194 Not sure of the ramifications of this change, but this fixes the encoding issues in FAKE for me. l.Head.Encoding was `System.IO.StringWriter(new System.Text.StringBuilder()).Encoding` which evaluates to utf-16 /cc:@forki
Fixes encoding issus on systems when encoding property is not set.