Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported Fake.Sql.DacPac to FAKE 5 #1878

Merged
merged 2 commits into from Apr 22, 2018
Merged

Conversation

josiahdj
Copy link
Contributor

I did my best to follow the guidelines and instructions for contributing. If I've missed something or done something that needs correcting me please let me know. This is my first "substantial" PR to FAKE.

@matthid matthid changed the base branch from master to rc_6 April 22, 2018 11:20
@@ -1,4 +1,5 @@
/// Contains helpers around deploying databases.
[<System.Obsolete("Please open Fake.Sql instead and use the Fake.Sql.DacPac module (FAKE0001 - package: Fake.Sql.DacPac, module: DacPac)")>]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a small problem. Because now you cannot actually fix that warning according to the migration guide (because old and new namespace are the same and we cannot include the new module into fakelib, because of naming conflict).

So we either remove this file and add only the new module (and have a breaking change because of RequireQualifiedAccess) or find a different solution

@matthid
Copy link
Member

matthid commented Apr 22, 2018

I'm trying to find a solution. Thanks for the PR!

@matthid matthid merged commit 6c47ca5 into fsprojects:rc_6 Apr 22, 2018
@josiahdj josiahdj deleted the PortDacPacToFake5 branch April 22, 2018 15:58
@matthid matthid mentioned this pull request Apr 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants