Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Pickles with Framework #1894 #1901

Merged
merged 3 commits into from May 4, 2018

Conversation

Projects
None yet
2 participants
@magicmonty
Copy link
Contributor

commented May 1, 2018

Add Process.withFramework for Fake.Tools.Pickles to ensure it runs not only in Windows

Updated Doc for a real working example

@@ -22,7 +24,8 @@ Target.create "BuildDoc" (fun _ ->
Pickles.convert (fun p ->
{ p with FeatureDirectory = currentDirectory </> "Specs"
OutputDirectory = currentDirectory </> "SpecDocs"
OutputFileFormat = Pickles.DocumentationFormat.DHTML })
OutputFileFormat = Pickles.DocumentationFormat.DHTML
ToolPath = Tools.findToolInSubPath "pickles.exe" "~/.fake/build.fsx/packages" })

This comment has been minimized.

Copy link
@matthid

matthid May 1, 2018

Collaborator

This is not something we should suggest. I consider the .fake directory basically implementation detail. I can see the problem but I don't have a good solution. Maybe we can automatically search in the users .nuget directory. This way it doesn't need to be copied in .fake.

This comment has been minimized.

Copy link
@magicmonty

magicmonty May 1, 2018

Author Contributor

@matthid Fine. Is there already a helper to get the .nuget directory of the user?
Because nearly all of my PR's (ReportGenerator, Pickles and SpecFlow) depend on a external NuGet package with the tool or the tool itself already installed.
I haven't found a different way yet. Maybe by setting the path in the Paket storage option explicitely?

This comment has been minimized.

Copy link
@matthid

matthid May 1, 2018

Collaborator

Maybe by setting the path in the Paket storage option explicitely?

I don't think this is supported ;)

I haven't found a different way yet.

Yes this is currently a PIA, the only resolution currently is to not use inline-dependencies but use a paket.dependencies file.

Is there already a helper to get the .nuget directory of the user?

Please just feel free to add one or create a similar helper to

let tryFindFileOnPath (file : string) : string option =

Just for searching in nuget. The remaining question is how we handle multiple versions? Maybe we return a list of (version, tool-path) and let the user choose?

This comment has been minimized.

Copy link
@matthid

This comment has been minimized.

Copy link
@magicmonty

magicmonty May 1, 2018

Author Contributor

@matthid Ok, I have a look then

@magicmonty magicmonty changed the title Run Pickles with Framework #1894 WIP: Run Pickles with Framework #1894 May 1, 2018

@magicmonty magicmonty force-pushed the magicmonty:pickles branch from 795d0e4 to 7d7d2ff May 2, 2018

@magicmonty magicmonty changed the title WIP: Run Pickles with Framework #1894 Run Pickles with Framework #1894 May 2, 2018

@magicmonty

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2018

@matthid I removed the "offending" part from the doc. I will make another PR for this eventually

@matthid

This comment has been minimized.

Copy link
Collaborator

commented May 4, 2018

I removed the "offending" part from the doc. I will make another PR for this eventually

Yes that makes sense to me. Thanks!

@matthid matthid changed the base branch from master to rc_11 May 4, 2018

@matthid matthid merged commit 3665748 into fsharp:rc_11 May 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@matthid matthid referenced this pull request May 6, 2018

Merged

Release Candidate 11 #1903

@magicmonty magicmonty deleted the magicmonty:pickles branch Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.