Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FakeRuntime to use NetStandard 2.0.3 #2106

Merged
merged 4 commits into from Sep 27, 2018

Conversation

Projects
None yet
2 participants
@BlythMeister
Copy link
Contributor

BlythMeister commented Sep 25, 2018

Description

I keep running into dotnet/standard#708 and this is apparently fixed in 2.0.3

I'm not sure if this has any other effects...

Update FakeRuntime to use NetStandard 2.0.3
I keep running into dotnet/standard#708 and this is apparently fixed in 2.0.3
@matthid

This comment has been minimized.

Copy link
Collaborator

matthid commented Sep 25, 2018

But we only use the package to have the reference assemblies, fake doesn't use the msbuild stuff, nor should it influence dependency resolution?

@matthid

This comment has been minimized.

Copy link
Collaborator

matthid commented Sep 25, 2018

(note I'm fine with the update if stuff still works ;))

@BlythMeister

This comment has been minimized.

Copy link
Contributor Author

BlythMeister commented Sep 25, 2018

Although the error was the same, the cause wasn't...I had corrupted my local nuget cache.

@matthid matthid reopened this Sep 25, 2018

@BlythMeister

This comment has been minimized.

Copy link
Contributor Author

BlythMeister commented Sep 27, 2018

This doesn't work and not sure we reallly need it...

@matthid

This comment has been minimized.

Copy link
Collaborator

matthid commented Sep 27, 2018

why does it not work?

@matthid

This comment has been minimized.

Copy link
Collaborator

matthid commented Sep 27, 2018

Normally this shouldn't hurt, maybe the ci was just running on a merge with my broken branch

@matthid matthid reopened this Sep 27, 2018

@matthid

This comment has been minimized.

Copy link
Collaborator

matthid commented Sep 27, 2018

Maybe I'm just merging this in, there might be some other place where 2.0.2 is hardcoded but we probably should unify those if that is the case

@BlythMeister

This comment has been minimized.

Copy link
Contributor Author

BlythMeister commented Sep 27, 2018

Err ok 😂

@matthid

This comment has been minimized.

Copy link
Collaborator

matthid commented Sep 27, 2018

But yeah some wtf is going on with these builds :/

@matthid

This comment has been minimized.

Copy link
Collaborator

matthid commented Sep 27, 2018

Fake reports

TemplateIntegrationTests        00:00:00.4552954   (DotNet CLI Template Integration tests failed.)

But output says:

[16:00:31 INF] EXPECTO! 8 tests run in 00:02:46.8871496 for Fake.Core.CommandLineParsing.Tests – 8 passed, 0 ignored, 0 failed, 0 errored. Success! <Expecto>
[16:00:31 INF] EXPECTO?! Summary...
Passed:  8
	Fake.Core.CommandLineParsing.Tests/issue #2025
	Fake.Core.CommandLineParsing.Tests/reference fake core targets
	Fake.Core.CommandLineParsing.Tests/use external paket.dependencies
	Fake.Core.CommandLineParsing.Tests/context exists
	Fake.Core.CommandLineParsing.Tests/reference fake runtime
	Fake.Core.CommandLineParsing.Tests/simple runtime error
	Fake.Core.CommandLineParsing.Tests/simple failed to compile
	Fake.Core.CommandLineParsing.Tests/no dependencies hello world
Ignored: 0
Failed:  0
Errored: 0 <Expecto>
@matthid

This comment has been minimized.

Copy link
Collaborator

matthid commented Sep 27, 2018

Ok scratch that I know what's going on

@BlythMeister

This comment has been minimized.

Copy link
Contributor Author

BlythMeister commented Sep 27, 2018

That makes one of us 😂

@matthid

This comment has been minimized.

Copy link
Collaborator

matthid commented Sep 27, 2018

Yes it wanted the latest changes/fixes from release/next ;)

@BlythMeister

This comment has been minimized.

Copy link
Contributor Author

BlythMeister commented Sep 27, 2018

@matthid this all good now?

@matthid matthid merged commit 2c2a0f4 into fsharp:release/next Sep 27, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@matthid

This comment has been minimized.

Copy link
Collaborator

matthid commented Sep 27, 2018

looks like it is

@matthid matthid referenced this pull request Sep 27, 2018

Merged

Release 5.8.4 #2116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.