Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeamCity Improvements #2138

Merged
merged 4 commits into from Oct 11, 2018

Conversation

Projects
None yet
2 participants
@BlythMeister
Copy link
Contributor

commented Oct 10, 2018

Description

  • Correcting TeamCity publish named artifacts
  • Add report build problems
  • Tidy TeamCity listener
  • Extract all messages into TeamCityInternal (which is internal...as the name suggests) and called by TeamCity (which is public). Added advantage is that messages can be used in many ways by different public methods. Also, the messages suddenly become strongly typed(ish)

@BlythMeister BlythMeister force-pushed the BlythMeister:teamcity branch from 81148ce to 26e13b5 Oct 10, 2018

@matthid

This comment has been minimized.

Copy link
Collaborator

commented Oct 10, 2018

Hm, I tried to merge in latest release/next changes into this PR and now apparently github cannot handle the diff anymore :(

@BlythMeister

This comment has been minimized.

Copy link
Contributor Author

commented Oct 10, 2018

I'll take a look in the morning 🙂

BlythMeister added some commits Oct 10, 2018

Refactor all messages sent to TeamCity into TeamCityInternal
This is easier to see and re-use message formats

@BlythMeister BlythMeister force-pushed the BlythMeister:teamcity branch from 004b57f to 5538310 Oct 11, 2018

@BlythMeister

This comment has been minimized.

Copy link
Contributor Author

commented Oct 11, 2018

i have rebased this (and all my other PRs)

@matthid

This comment has been minimized.

Copy link
Collaborator

commented Oct 11, 2018

Thanks I thought stuff would go green again but this azure pipeline thing doesn't seem to be well thought through...

@BlythMeister

This comment has been minimized.

Copy link
Contributor Author

commented Oct 11, 2018

:( that's a shame...

@matthid
Copy link
Collaborator

left a comment

looks good to me

@matthid matthid merged commit ce3a2c7 into fsharp:release/next Oct 11, 2018

3 of 4 checks passed

FAKE-CI #649 failed
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@matthid

This comment has been minimized.

Copy link
Collaborator

commented Oct 11, 2018

Thanks!

@matthid matthid referenced this pull request Oct 12, 2018

Merged

Release 5.9 #2137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.