Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MSBuild 16 / VS 2019 #2274

Merged
merged 2 commits into from Mar 16, 2019

Conversation

Projects
None yet
4 participants
@csmager
Copy link
Contributor

commented Mar 14, 2019

VS2019 changes the location of MSBuild from e.g. MSBuild\15.0\Bin to MSBuild\Current\Bin. This is noted in the VSWhere Wiki:

Starting in Visual Studio 2019 Preview, MSBuild will use "Current" instead of the major version number to make it easier to invoke for different versions.

This changes the approach to search all folders within MSBuild for Bin\MSBuild.exe and reads the major version from the executable itself.

The fix is as suggested by @vbfox in a comment to the issue. I've tested on my machine with only VS 2019 RC installed, MSBuild 16 is now picked instead of MSBuild 14.

Fixes #2271

Add support for MSBuild 16 / VS 2019
VS2019 changes the location of MSBuild from e.g.
MSBuild\15.0\Bin to MSBuild\Current\Bin.

This changes the approach to search all folders within MSBuild for
Bin\MSBuild.exe and reads the major version from the executable itself.
@BlythMeister

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2019

@matthid / @forki maybe we should release a Fake 4 release that supports this new path too? - see #2277 just in case :)

@vbfox

vbfox approved these changes Mar 16, 2019

@matthid

This comment has been minimized.

Copy link
Collaborator

commented Mar 16, 2019

Ok, thanks for taking care of this!

@matthid matthid merged commit c4564fd into fsharp:release/next Mar 16, 2019

4 checks passed

FAKE-CI #935 succeeded
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@csmager csmager deleted the csmager:msbuild-16 branch Mar 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.