Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paket Update #2286

Merged
merged 5 commits into from Apr 4, 2019

Conversation

Projects
None yet
2 participants
@BlythMeister
Copy link
Contributor

commented Apr 3, 2019

Description

  • Update paket cli version in dependencies to 5.200.4
  • Run paket update command

Required due to new setting in 5.200.4 from PR fsprojects/Paket#3523

matthid and others added some commits Feb 26, 2019

@matthid

This comment has been minimized.

Copy link
Collaborator

commented Apr 3, 2019

Typical paket update, everything broken

@matthid

This comment has been minimized.

Copy link
Collaborator

commented Apr 3, 2019

##[error]Fsc: D:\a\1\s\src\app\Fake.netcore\Program.fs(306,33): error FS0039: The constructor, module or namespace 'DNXCore' is not defined.

I think some minor code adjustments are required for the breaking changes in paket

@BlythMeister

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

@matthid tbf...it was my change that broke the 1st thing....@forki was the other one :p

Have updated to remove DNXCore as that value no longer exists as an option :)

@matthid

This comment has been minimized.

Copy link
Collaborator

commented Apr 4, 2019

Thanks a lot for taking care of this :)

@matthid matthid merged commit ab4883b into fsharp:release/next Apr 4, 2019

3 of 4 checks passed

ci/circleci Your tests failed on CircleCI
Details
FAKE-CI #951 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@matthid matthid referenced this pull request Apr 8, 2019

Merged

Release 5.13.0 #2279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.