Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack webhook username not from #2360

Merged
merged 4 commits into from Jul 27, 2019

Conversation

@mastion
Copy link
Contributor

commented Jul 26, 2019

Description

Setting the username of an incoming slack message was not working. It was due to an incorrectly named field. Instead of From the field should be Username.
Also modified the documentation

No issue for this. I brought it up in the gitter.

TODO

Feel free to open the PR and ask for help

  • New (API-)documentation for new features exist (Note: API-docs are enough, additional docs are in help/markdown)

  • unit or integration test exists (or short reasoning why it doesn't make sense)

    Note: Consider using the CreateProcess API which can be tested more easily, see https://github.com/fsharp/FAKE/pull/2131/files#diff-4fb4a77e110fbbe8210205dfe022389b for an example (the changes in the DotNet.Testing.NUnit module)

  • boy scout rule: "leave the code behind in a better state than you found it" (fix warnings, obsolete members or code-style in the places you worked in)

  • (if new module) the module has been linked from the "Modules" menu, edit help/templates/template.cshtml, linking to the API-reference is fine.

  • (if new module) the module is in the correct namespace

  • (if new module) the module is added to Fake.sln (dotnet sln Fake.sln add src/app/Fake.*/Fake.*.fsproj)

  • Fake 5 API guideline is honored

matthid and others added 4 commits Jul 16, 2019
Release 5.15.4
Changed the namespace because the script I was testing with already had
Fake added and I wasn't sure if #r-ing SlackNotification.fs into the
script would mess up if they were in the same namespace. So I changed
it and now I am deleting it.
@mastion

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2019

I didn't see any integration tests for this ( probably because you don't have a slack server hanging around for testing ). I tested this manually and it worked. I am not sure what other information you might need for this.
I assumed I shouldn't delete SlackNotificationHelper.fs even though all of it is obsolete. But happy too if you want.
Sorry if I missed something obvious!

@matthid

This comment has been minimized.

Copy link
Collaborator

commented Jul 27, 2019

@mastion thanks looks good to me. Usually we add unit-tests for bugfixes but in this case I'm not sure what we could test so...

@matthid matthid merged commit e85096b into fsharp:release/next Jul 27, 2019
3 checks passed
3 checks passed
FAKE-CI #1171 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@matthid matthid referenced this pull request Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.