Join GitHub today
Slack webhook username not from #2360
Setting the username of an incoming slack message was not working. It was due to an incorrectly named field. Instead of
No issue for this. I brought it up in the gitter.
Feel free to open the PR and ask for help
Basing this off local testing and the slack api node sdk https://github.com/slackapi/node-slack-sdk/blob/e771e3c6fb346c42f6c86baba76223485c5c1024/packages/webhook/src/IncomingWebhook.ts#L92
Changed the namespace because the script I was testing with already had Fake added and I wasn't sure if #r-ing SlackNotification.fs into the script would mess up if they were in the same namespace. So I changed it and now I am deleting it.
I didn't see any integration tests for this ( probably because you don't have a slack server hanging around for testing ). I tested this manually and it worked. I am not sure what other information you might need for this.