Join GitHub today
Add TargetCommitish to CreateReleaseParams #2367
I don't know. :(
I tested it by copy/pasting the whole createRelease function directly into my build script.
What kind of tests would you like to see? Examples of tests of other API calls would be helpful as I'm unfamiliar with the codebase.
Just asking I don't have anything particular in mind. Just assumed you are more familiar with the github api.
Ideally something which verifies that this works without the need for me to test manually ;)
Sadly, I don't think we have any.
In any case this looks good to me, so I guess I'll just merge as is...
Unfortunately, I'm not. I just assumed there's a way for me to create a release without a tag. After not finding a parameter in CreateReleaseParams I looked under the hood to find the Octokit's NewRelease and there it was. Tested it; it worked; thought it might be useful to others and so here we are.