Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.19 #2425

Merged
merged 111 commits into from Dec 19, 2019
Merged

Release 5.19 #2425

merged 111 commits into from Dec 19, 2019

Conversation

@matthid
Copy link
Collaborator

matthid commented Nov 4, 2019

  • NEW: Added Fake.Sql.SqlPackage which is a redesign or Fake.Sql.DacPac and added support for publish profiles, thanks @kmadof - #2366
  • EHNANCEMENT: Fake.DotNet.Cli Add timeout field to kill the process after the given timeout - #2425
  • EHNANCEMENT: Fake.Core.Target Add notification when a fake worker is idle - #2425
  • EHNANCEMENT: Use SPDX license expressions in the nuspec files, thanks @teo-tsirpanis - #2403
  • ENHANCEMENT: fake-cli Update bundled paket - #2425
  • ENHANCEMENT: Fake.DotNet.Cli Add support for suppressing copyright messages (--nologo) when invoking dotnet, thanks @objectx - #2436
  • EHNANCEMENT: Fake.Installer.Squirrel Add additional Squirrel parameters, thanks @pchinery - #2431
  • EHNANCEMENT: Fake.Testing.SonarQube Several improvements like workdir and local tool support, thanks @vilinski - #2438
  • BUGFIX: Fake.Tools.Rsync Fix typo in Rsync.fs options, thanks @rmunn - #2432
  • BUGFIX: Fake.DotNet.Testing.Coverlet Fix Coverlet output property name, thanks @SteveGilham - #2427
  • BUGFIX: Fake.Tools.Octo Octopus deploy trace always marked failures, thanks @ids-pfinn - #2428
  • BUGFIX: Fake.Core.Process Process redirection was not working as advertised, thanks @ZeekoZhu - #2445
  • DOCS: Change the README badges and their placement, thanks @teo-tsirpanis - #2437
  • DOCS: Several documentation improvements, thanks to @jhromadik - #2441 #2442 #2443
Krzysztof Madej and others added 30 commits Jul 22, 2019
This also increases build speed, as we don't need to download the .NET SDK every time at the beginning.
Remove a reference to PackageLicenseURL.
forgot how partial application works and that it is not just magic.
also forgot ignore is a function.
Fix property name
Fix typo in Rsync.fs options
…marked-failures

Octopus deploy trance always marked failures
Create Github Actions
matthid added 15 commits Dec 17, 2019
Fixing incorrect indentation in the right menu
Decrease footer z-index so that main menu is not hidden behind it
Fixed "Visual Studio for Windows" download link
Sonarscanner
Add support for publish profiles
@matthid

This comment was marked as resolved.

Copy link
Collaborator Author

matthid commented Dec 18, 2019

Just tried the fake-cli --version 5.19.0-alpha.1439 to run on my win10:
fake --version Error: An assembly specified in the application dependencies manifest (fake-cli.deps.json) was not found: package: 'Packaging.Targets', version: '0.1.153' path: 'runtimes/win7-x64/native/lzma.dll'

@matthid

This comment was marked as resolved.

Copy link
Collaborator Author

matthid commented Dec 18, 2019

@teo-tsirpanis So apparently switching to dotnet deb tool broken the regular fake-cli tool :(

@matthid

This comment was marked as resolved.

Copy link
Collaborator Author

matthid commented Dec 18, 2019

$ fake --version
FAKE 5 - F# Make (5.19.0-alpha.1439+vsts.6c029f59eb41055d91fd6c208566d17ac3270600) (this line is written to standard error, see #2066)
FakePath: ~/.dotnet/tools/.store/fake-cli/5.19.0-alpha.1439/fake-cli/5.19.0-alpha.1439/tools/netcoreapp2.1/any/Fake.Runtime.dll
Paket.Core: 1.0.0

Seems on Mac the Paket.Core version is wrong.

matthid added 9 commits Dec 18, 2019
@matthid matthid merged commit 8f396fb into master Dec 19, 2019
5 of 7 checks passed
5 of 7 checks passed
greeting
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
FAKE-CI #5.19.0 succeeded
Details
ci/gitlab/release/next Pipeline passed on GitLab
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@otto-gebb

This comment has been minimized.

Copy link
Contributor

otto-gebb commented on src/app/Fake.Core.Process/RawProc.fs in a14070f Dec 24, 2019

A couple of debugger.breaks here and there. Are they left intentionally?

This comment has been minimized.

Copy link
Collaborator Author

matthid replied Dec 25, 2019

@otto-gebb not really, I think I removed them before doing the release. For some reason 'normal' breakpoints didn't work that day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.