New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AppVeyor and SourceLink support #345

Merged
merged 1 commit into from Mar 28, 2014

Conversation

Projects
None yet
3 participants
@ctaggart
Copy link
Contributor

ctaggart commented Mar 3, 2014

The pull request isn't complete yet, but it is a start and all I have time for tonight.
https://ci-beta.appveyor.com/project/ctaggart/fake

The FSharp.Data pull request fsharp/FSharp.Data#479 is more complete if you wish to look at it for comparison. I have not added the #if Mono stuff yet. I'm not sure how you want to do versions. I've been doing CI builds with the current date in the prerelease. It's up to you. Just thought I'd get feedback.

@forki

This comment has been minimized.

Copy link
Member

forki commented Mar 3, 2014

Sounds good.
Do you plan to contribute a AppVeyor helper in FAKE? I think it would be nice to have better integration, like making FAKE aware of AppVeyors Tests tab. Maybe there is some way to report test results.

forki added a commit that referenced this pull request Mar 28, 2014

Merge pull request #345 from ctaggart/appveyor
add AppVeyor and SourceLink support

@forki forki merged commit 46b76b8 into fsharp:develop Mar 28, 2014

1 check failed

default The Travis CI build failed
Details
open System.IO
open SourceLink

let (!!) includes = (!! includes).SetBaseDirectory __SOURCE_DIRECTORY__

This comment has been minimized.

@forki

forki Mar 28, 2014

Member

why are you doing this? Would like to get rid of this again

@forki

This comment has been minimized.

Copy link
Member

forki commented Mar 28, 2014

I'm getting this now:

image

@forki

This comment has been minimized.

Copy link
Member

forki commented Mar 28, 2014

any ideas?

@thinkbeforecoding

This comment has been minimized.

Copy link
Contributor

thinkbeforecoding commented Mar 28, 2014

Do you link to a specific revision of the repository ? or just the latest ?

@forki

This comment has been minimized.

Copy link
Member

forki commented Mar 28, 2014

I just merged the PR. Not really sure what I'm doing here.

@thinkbeforecoding

This comment has been minimized.

Copy link
Contributor

thinkbeforecoding commented Mar 28, 2014

I don't know exactly how sourcelink work especially but...
When retrieving source, visual studio will verify that the checksum embedded in the .pdb file is the same as the downloaded source code. If not, you'll get a warning that the source code is not the same than during compilation.

This is why sourcelink is verifying checksum..

But for it to run, it is important that the link to the source code is a link to the exact same version. With a link to github, the link should contain the exact commit.

It's probably what is failing here.

@forki forki referenced this pull request Mar 28, 2014

Merged

Issue296 #376

@forki

This comment has been minimized.

Copy link
Member

forki commented Mar 28, 2014

the problem is: how can I fix it?

@forki

This comment has been minimized.

Copy link
Member

forki commented Mar 28, 2014

Now I get
image

@ctaggart ctaggart deleted the ctaggart:appveyor branch Jun 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment