NuGet: support building symbol+source packages without project file #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NuGet supports building symbol/source packages automatically when specifying the project file. However, it is also possible to build such packages manually without a project file but instead a nuspec file, where the symbols and sources are specified explicitly. The default behavior is unchanged: symbol packages are built if and only if a project file is provided (in this case we generate, as before, first both packages with the project file, then overwrite the normal package using the generated nuspec). If symbol packages should be built with the nuspec file, then specify p.Symbols = NugetSymbols.Nuspec.
|
@shiftkey would this work for you too? |
|
@forki oh man, it just might. Happy to review and test it out if you can wait a few days (currently at a conference) |
forki
added a commit
that referenced
this pull request
Jun 2, 2014
NuGet: support building symbol+source packages without project file
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NuGet supports building symbol/source packages automatically when specifying the project file. However, it is also possible to build such packages manually without a project file but instead a nuspec file, where the symbols and sources are specified explicitly. To my understanding this second approach without a project file is not currently supported with Fake.
The default behavior is unchanged: symbol packages are built if and only if a project file is provided (in this case we generate, as before, first both packages with the project file, then overwrite the normal package using the generated nuspec). If symbol packages should be built with the nuspec file, then specify p.SymbolPackage = NugetSymbolPackage.Nuspec.
I'm not very happy with this design, but it was the best I came up with that does not break existing behavior and does not require introducing a whole new set of NuGetXY-like functions. I happily update the PR if someone has a better idea. Thanks.