Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Display agent success / error messages in UI #735
Currently, no arguments are passed to the agent from Deploy.Web. This pull request passes env=EnvironmentName for the agent. This lets us parameterize deployments. Currently, the mechanism of passing multiple arguments alongside a package POST adds them as a ; separated string, which is then available in the deployment script verbatim. This pull request changes to the approach outlined by RFC 2616 (http://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html) where multiple values are added to the header comma separated and quoted, with only quote characters percent encoded. To support existing clients, POSTs without comma separated quoted format are still passed verbatim.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.