Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FAKE not working on machines with only F# 4.0 installed #784

Merged
merged 1 commit into from May 5, 2015

Conversation

Projects
None yet
3 participants
@ovatsus
Copy link
Member

commented May 4, 2015

No description provided.

forki added a commit that referenced this pull request May 5, 2015

Merge pull request #784 from ovatsus/master
Fix FAKE not working on machines with only F# 4.0 installed

@forki forki merged commit e990312 into fsharp:master May 5, 2015

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@forki

This comment has been minimized.

Copy link
Member

commented May 5, 2015

thanks

@forki

This comment has been minimized.

Copy link
Member

commented May 5, 2015

image

If I build locally on system with VS 2013 + VS 2015 RC I now get method not found errors.

@ovatsus

This comment has been minimized.

Copy link
Member Author

commented May 5, 2015

:( Maybe the binding redirect in app.config needs updating? Or maybe we can just reorder so 4.0 comes after 3.1

@forki

This comment has been minimized.

Copy link
Member

commented May 6, 2015

ok the issue is not this, but @ctaggart's #783.
I had to revert that (otherwise nice change) and everything works again.

@ctaggart

This comment has been minimized.

Copy link
Contributor

commented May 6, 2015

:(

@ctaggart

This comment has been minimized.

Copy link
Contributor

commented May 6, 2015

What is the FAKE version with the problem? I'll take a look and find the root cause when I get a chance.

@forki

This comment has been minimized.

Copy link
Member

commented May 6, 2015

There is no published version with a bug. It's just that I can't build (due
to test errors) on the machine where I do the release. So I reverted your
changes and it builds again. Only tests in FAKE.deploy Web stuff are
affected.
On May 6, 2015 9:09 AM, "Cameron Taggart" notifications@github.com wrote:

What's the FAKE version with the problem? I'll take a look and find the
root cause when I get a chance.


Reply to this email directly or view it on GitHub
#784 (comment).

@ctaggart

This comment has been minimized.

Copy link
Contributor

commented May 6, 2015

The looks like a binding redirect problem. How do I reproduce?

@forki

This comment has been minimized.

Copy link
Member

commented May 6, 2015

I have VS2015 rc and f# 3.1 installed. Then try to build your commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.