Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation, build script, embeddable F# interactive #10

Merged
21 commits merged into from Dec 23, 2013

Conversation

tpetricek
Copy link
Member

The aim is to make this proper F# open source project with the standard documentation & tools. The changes are:

  • Add FAKE build script to build everything, publish NuGet package etc.
  • Add documentation for some components (work in progress)
  • Add embeddable F# Interactive (FSharp.Interactive.Service.dll)
  • Rename the compiler DLL to FSharp.Compiler.Service.dll

The two work items that I still need to finish are:

  • Make sure that NuGet package is build properly
  • Add documentation for Editor & Embedded FSI

@7sharp9
Copy link
Member

7sharp9 commented Dec 21, 2013

You have merge conflicts, is this 3.1 based or 3.0? The work Don's been doing is in the fsharp_31 branch ...

@tpetricek
Copy link
Member Author

The changes I did are based on the F# 3.1 version. If I understand it correctly, this has now been merged to the master branch (this is where your pull request went), so the master is now F# 3.1 (which sounds like the best option to me).

@forki
Copy link
Member

forki commented Dec 22, 2013

From the readme it's still 3.0

@ghost
Copy link

ghost commented Dec 22, 2013

That needs to be updated

@tpetricek
Copy link
Member Author

I integrated the readme into the documentation pages and updated it there. I think the main readme file can be just very minimalistic with a link to the documentation.

I won't be able to update the pull request soon so feel free to copy & paste something from the denotes.MD and index.MD. Thanks!

@tpetricek
Copy link
Member Author

I added minimal README that links to the updated developer notes document (former readme) and fixed incorrect NuGet links in the documentation.

ghost pushed a commit that referenced this pull request Dec 23, 2013
Add documentation, build script, embeddable F# interactive
@ghost ghost merged commit c0d07b0 into fsharp:master Dec 23, 2013
dsyme pushed a commit to dsyme/FSharp.Compiler.Service that referenced this pull request Mar 23, 2015
…nvBindTypeRef fsharp#9

Fixes fsharp#10, internal error: binding null type in envBindTypeRef

Both issues were caused by the same underlying issue.  RefEmit automagically applies escaping to names that contain a ','  So ``,`` becomes ``\,``.  When we tried to create a ref to a nested type we didn't add the ',' escaping so we couldnot bind to the created type.

The fix is very straightforward, change BasicQualifiedName to correctly escape names with comma's.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants