Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out Fsharp.Data.Json.Core etc #1311

Closed
cartermp opened this issue Mar 30, 2020 · 16 comments
Closed

Split out Fsharp.Data.Json.Core etc #1311

cartermp opened this issue Mar 30, 2020 · 16 comments

Comments

@cartermp
Copy link
Collaborator

The support matrix for this package is quite high, which makes adopting updates to things (tools, F# compiler) and contributions tricky and potentially error-prone. I think moving to NS 2.0 only, with a major version bump, might be good for the long-term health of the pakage.

@pimbrouwers
Copy link

Piggybacking on this, which I completely agree with. Maybe we move away from the single-package, in favor of separate smaller packages. For example: FSharp.Data.Html and FShar.Data.Json as separate packages.

@pimbrouwers
Copy link

pimbrouwers commented Apr 8, 2020

For anyone interested, I've done this specifically for the Json functionality (provider and http functionality excluded). It was really quite painless.

https://github.com/pimbrouwers/FSharp.Data.Json

@cartermp
Copy link
Collaborator Author

cartermp commented Apr 8, 2020

@pimbrouwers the FSharp.Data.Json splitting out looks like a great idea. Splitting out each of the type providers would have some benefits:

However, the downsides are somewhat large. Asking users to move from a single package like this into separate ones is quite a task for the large number of people who depend on this package.

Overall I'd be in favor of that kind of split, but I think more folks involved with this package would have to have a say

@pimbrouwers
Copy link

@cartermp brilliantly put. I agree on all fronts.

As far as the migration is concerned, perhaps there could be a deprecation period where the single & multi-package implementations are maintained in parallel. With the understanding that the single package would one day be deprecated.

Perhaps we tackle these problems separately:

  • Work toward netstandard2.0 compliance.
  • Once established, we can begin teasing apart the tentacles. A separate package for: JSON, HTML, CSV etc.
  • Both implementations, single and multi, are maintained in parallel for a period.

@cartermp
Copy link
Collaborator Author

cartermp commented Apr 9, 2020

Curious what @dsyme thinks here.

@dsyme
Copy link
Contributor

dsyme commented Jun 1, 2020

I think this would be great

@cartermp cartermp changed the title Consider supporting on .NET Standard 2.0 Consider standardizing on .NET Standard 2.0 Jun 1, 2020
@CaringDev
Copy link

... single & multi-package implementations ...

Or the existing package could be changed to a meta-package referencing all the new ones. This could even be done tentacle by tentacle.

@joshuapassos
Copy link

It's possible change multi-package ? Is there a roadmap for migration?

@dsyme
Copy link
Contributor

dsyme commented Feb 11, 2021

I'm renaming this issue to be about splitting out FSharp.Data.Json etc

@dsyme dsyme changed the title Consider standardizing on .NET Standard 2.0 Split out Fsharp.Data.Json etc Feb 11, 2021
@toburger
Copy link

toburger commented Mar 22, 2021

A welcome separation! I often use FSharp.Data solely for it's JSON utility functions.

@dsyme
Copy link
Contributor

dsyme commented Aug 15, 2022

@pimbrouwers Could you give "fsprojects" ownership of the package "FSharp.Data.Json" please? We'd potentially like to use it here: #1457 , see https://www.nuget.org/packages/FSharp.Data.Json

@pimbrouwers
Copy link

pimbrouwers commented Aug 15, 2022

Sure thing! Is this the correct method? If so, which account:

Screenshot_20220815-175138

Or are you speaking about the NuGet package?

@dsyme
Copy link
Contributor

dsyme commented Aug 15, 2022

@pimbrouwers The nuget package - I think you add "fsprojects" as org https://www.nuget.org/profiles/fsprojects

@pimbrouwers
Copy link

@dsyme done!

Screenshot_20220815-184700

@pimbrouwers
Copy link

A welcome separation! I often use FSharp.Data solely for it's JSON utility functions.

@toburger might be worth checking out Jay, which is a fork of FSharp.DataJson with some optimizations and refinements. We use it a lot at the NHLPA with great success, you might find it useful as well!

@dsyme
Copy link
Contributor

dsyme commented Aug 17, 2022

This is now merged and released as FSharp.Data 5.0.1

@dsyme dsyme changed the title Split out Fsharp.Data.Json etc Split out Fsharp.Data.Json.Core etc Aug 17, 2022
@dsyme dsyme closed this as completed Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants