New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out Fsharp.Data.Json.Core etc #1311
Comments
Piggybacking on this, which I completely agree with. Maybe we move away from the single-package, in favor of separate smaller packages. For example: FSharp.Data.Html and FShar.Data.Json as separate packages. |
For anyone interested, I've done this specifically for the Json functionality (provider and http functionality excluded). It was really quite painless. |
@pimbrouwers the FSharp.Data.Json splitting out looks like a great idea. Splitting out each of the type providers would have some benefits:
However, the downsides are somewhat large. Asking users to move from a single package like this into separate ones is quite a task for the large number of people who depend on this package. Overall I'd be in favor of that kind of split, but I think more folks involved with this package would have to have a say |
@cartermp brilliantly put. I agree on all fronts. As far as the migration is concerned, perhaps there could be a deprecation period where the single & multi-package implementations are maintained in parallel. With the understanding that the single package would one day be deprecated. Perhaps we tackle these problems separately:
|
Curious what @dsyme thinks here. |
I think this would be great |
Or the existing package could be changed to a meta-package referencing all the new ones. This could even be done tentacle by tentacle. |
It's possible change multi-package ? Is there a roadmap for migration? |
I'm renaming this issue to be about splitting out FSharp.Data.Json etc |
A welcome separation! I often use FSharp.Data solely for it's JSON utility functions. |
@pimbrouwers Could you give "fsprojects" ownership of the package "FSharp.Data.Json" please? We'd potentially like to use it here: #1457 , see https://www.nuget.org/packages/FSharp.Data.Json |
@pimbrouwers The nuget package - I think you add "fsprojects" as org https://www.nuget.org/profiles/fsprojects |
@dsyme done! |
This is now merged and released as FSharp.Data 5.0.1 |
The support matrix for this package is quite high, which makes adopting updates to things (tools, F# compiler) and contributions tricky and potentially error-prone. I think moving to NS 2.0 only, with a major version bump, might be good for the long-term health of the pakage.
The text was updated successfully, but these errors were encountered: