New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parsing of fproj project (new sdk) #161

Open
enricosada opened this Issue Apr 18, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@enricosada
Collaborator

enricosada commented Apr 18, 2017

Current implementation for new sdk (the .net core sdk), starts reading from an fsproj project file and from there traverse the project references to parse and discover more projects.

From each project, to get fsc args and project references, msbuild is called as process.

Some possibile improvements (from easier to harder):

  • cache already parsed projects (if A ref B, and C ref B, than B should be parsed just once). ref
    //TODO cache projects info of p2p ref
    . Helps if deep dependency tree, with common projects
  • Run in parallel the msbuild processes. Helps if broad dependency tree, if a project is flat with multiple project references
  • Invoke msbuild process async, no need to wait
  • Lock msbuild executions, because async request may run msbuild on same project concurrently (one will wait and fail, but waste resources)
  • Use a small pool of msbuild processes

all changes should be inside https://github.com/fsharp/FsAutoComplete/blob/master/src/FsAutoComplete.Core/ProjectCoreCracker.fs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment