Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HTTP communication layer #395

Closed
Krzysztof-Cieslak opened this issue Jun 5, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@Krzysztof-Cieslak
Copy link
Collaborator

commented Jun 5, 2019

As far as I know Ionide was only user of the HTTP version of FSAC. As Ionide will move towards LSP pretty soon, I think it's good moment to remove HTTP support - it would simplify code base, and reduce number of dependencies.

@enricosada

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

Yes, it’s fine to remove it.

I’ll do that as single PR so i can eventually revert it if needed by someone (don’t think so)

You want to remove it before ionide 4 ship?
The overhead is not a lot, we can cleanup after it is released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.