Don't panic on malformed JSON (debug messages)

[juergenhoetzel]

Instead just log parsing errors and try to parse next line. Fixes #130.

[rneatherway]

Seems reasonable, thanks. I agree the F# compiler should not be outputting this stuff to stdout. It does worry me a little that people might find debugging hard if there is a stack trace and we throw it away though. Any idea how we might get around that issue? On 2 Jun 2017 7:24 a.m., "Jürgen Hötzel" <notifications@github.com> wrote: Instead just log parsing errors and try to parse next line. Fixes #130 <#130>. ------------------------------ You can view, comment on, or merge this pull request online at: #131 Commit Summary - Don't panic on malformed JSON (debug messages) File Changes - *M* fsharp-mode-completion.el <https://github.com/fsharp/emacs-fsharp-mode/pull/131/files#diff-0> (4) Patch Links: - https://github.com/fsharp/emacs-fsharp-mode/pull/131.patch - https://github.com/fsharp/emacs-fsharp-mode/pull/131.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#131>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAO5G_vz3m1M36hS1WCfAjKBZNEVnJ88ks5r_46DgaJpZM4Nt0Kl> .

[juergenhoetzel]

It does worry me a little that people might find
debugging hard if there is a stack trace and we throw it away though. Any
idea how we might get around that issue?

I'm not sure what you mean with "throw the stack trace away".

• Currently no stack trace is shown if the the user didn't set (setq debug-on-error t)
• Users can still check *fsharp-debug* if something doesn't work and use edebug to set breakpoint

[juergenhoetzel]

By the way: In tramp we use tramp-debug-message for logging.
I automatically logs function-name/arguments to provide useful debug-information by default whithout verbose syntax? IMO this would also help debugging issues like this? What do you think?

[rneatherway]

Sorry, I meant an F# stack trace, which happened a few times with mono bugs or unsigned Fsharp.core.dll. You're right to say it should be in the *fsharp-debug* buffer in any case. I will merge this and do a release when I'm back at my computer on Monday. The tramp-debug-message sounds useful, I wasn't aware of that. Thanks a lot Jürgen! On 2 Jun 2017 6:35 p.m., "Jürgen Hötzel" <notifications@github.com> wrote: By the way: In *tramp* we use tramp-debug-message for logging. I automatically logs function-name/arguments to provide useful debug-information by default whithout verbose syntax? IMO this would also help debugging issues like this? What do you think? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#131 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAO5G9q-HG4fyRs4RGrwD5-sX45A5v4yks5sACuzgaJpZM4Nt0Kl> .

[rneatherway]

Thanks for the PR, 1.9.7 including it should be live on MELPA by tomorrow.