Skip to content

Conversation

@Gastove
Copy link
Contributor

@Gastove Gastove commented Jun 3, 2017

I found a couplefew more little bugs with my font locking revamp! This fixes 'em:

[||] <- the first pipe was being locked when it oughtn't be

<| <- was not being locked at all.

@Gastove
Copy link
Contributor Author

Gastove commented Jun 3, 2017

Well, so. Ran make test locally, which passed; forgot to run make test-all which very clearly doesn't. However, the failures seem to be about completion? I sure... don't think I touched completion.

If anyone has an intuition about what the heck has gone sideways here, I'd love a Hint in the right direction. I'll get digging, see if I can figure out what's happened.

@rneatherway
Copy link
Member

rneatherway commented Jun 3, 2017 via email

@juergenhoetzel
Copy link
Collaborator

Hey don't worry about those other tests, it can't have been you that broke
it. I'll take a look.

According to travis output

Error: F# completion process produced malformed JSON (non-IL or abstract method with non-zero RVA
non-IL or abstract method with non-zero RVA

this is caused by Malformed JSON "non-IL or abstract method with non-zero RVA", fixed by Don't panic on malformed JSON (debug messages)

@Gastove
Copy link
Contributor Author

Gastove commented Jun 4, 2017

AH. Okay, cool -- I didn't have time to look at the other bug reports/errors. Thanks, @juergenhoetzel

@rneatherway rneatherway merged commit 5b96ba2 into fsharp:master Jun 6, 2017
@rneatherway
Copy link
Member

Thanks for the PR, 1.9.7 including it should be live on MELPA by tomorrow.

juergenhoetzel pushed a commit to juergenhoetzel/emacs-fsharp-mode that referenced this pull request Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants