New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #r so mono fsi has some behaviour than .NET fsi #251

Closed
ovatsus opened this Issue Jan 31, 2014 · 9 comments

Comments

Projects
None yet
5 participants
@ovatsus
Member

ovatsus commented Jan 31, 2014

There seems to be a difference in assembly resolution where in mono:

#r "a/b/c.dll"

doesn't find dependencies of "c.dll" in directory in directory "a/b", while in .NET it works fine.
People usually adjust this to:

#I "a/b"
#r "a/b/c.dll"

But it's something every F# library hits when someone first try it on mono.
We should definitely fix this

@ovatsus

This comment has been minimized.

Show comment
Hide comment
@ovatsus

ovatsus Feb 28, 2014

Member

ping

Member

ovatsus commented Feb 28, 2014

ping

@jpalmer

This comment has been minimized.

Show comment
Hide comment
@jpalmer

jpalmer Feb 28, 2014

Contributor

For a real world example:

jpalmer/FSharpRProvider@e6e8f8d

Contributor

jpalmer commented Feb 28, 2014

For a real world example:

jpalmer/FSharpRProvider@e6e8f8d

@7sharp9

This comment has been minimized.

Show comment
Hide comment
@7sharp9

7sharp9 Feb 28, 2014

Member

We shouldn't have to add a #I everywhere, I have seen situations in fsahrp.formatting where that doesn't help. I wish this could be fixed too.

Member

7sharp9 commented Feb 28, 2014

We shouldn't have to add a #I everywhere, I have seen situations in fsahrp.formatting where that doesn't help. I wish this could be fixed too.

@7sharp9

This comment has been minimized.

Show comment
Hide comment
@7sharp9

7sharp9 Feb 28, 2014

Member

There are quite a few runningOnMono flags which I think need to be reviewed.

I remember seeing some different behaviours because xbuild was not mature, as that is the default on mono now maybe those flags can be removed.

We need to look through the code to see if we can find this.

Member

7sharp9 commented Feb 28, 2014

There are quite a few runningOnMono flags which I think need to be reviewed.

I remember seeing some different behaviours because xbuild was not mature, as that is the default on mono now maybe those flags can be removed.

We need to look through the code to see if we can find this.

@rneatherway

This comment has been minimized.

Show comment
Hide comment
@rneatherway

rneatherway Apr 9, 2014

Member

Is this one still going to be fixed here or will it go over to codeplex? I've just had someone contact me about the emacs support when doing this F# dojo: https://github.com/c4fsharp/Dojo-Type-Provider-Treasure-Hunt/blob/master/Dojo/Script.fsx

The problem was this issue, which we should definitely fix.

Member

rneatherway commented Apr 9, 2014

Is this one still going to be fixed here or will it go over to codeplex? I've just had someone contact me about the emacs support when doing this F# dojo: https://github.com/c4fsharp/Dojo-Type-Provider-Treasure-Hunt/blob/master/Dojo/Script.fsx

The problem was this issue, which we should definitely fix.

@7sharp9

This comment has been minimized.

Show comment
Hide comment
@7sharp9

7sharp9 Apr 9, 2014

Member

I thought x-plat issues were for here.

Member

7sharp9 commented Apr 9, 2014

I thought x-plat issues were for here.

@rneatherway

This comment has been minimized.

Show comment
Hide comment
@rneatherway

rneatherway Apr 9, 2014

Member

Ah yes, I re-read the announcement, you're right.

Member

rneatherway commented Apr 9, 2014

Ah yes, I re-read the announcement, you're right.

dsyme pushed a commit to dsyme/fsharp that referenced this issue Mar 22, 2015

Structured format display attribute multiple props
closes #251

commit a85f4d6c23066f36513f003392c0d4674316e750
Author: Sven Grosen <svengrosen@gmail.com>
Date:   Thu Mar 12 14:23:16 2015 -0500

    remove more commented out code

commit a6ea1051b337e9e87d6ec97182c6730775aaf696
Author: Sven Grosen <svengrosen@gmail.com>
Date:   Thu Mar 12 14:22:38 2015 -0500

    remove commented out code

commit 3900ba3b3d72236552bad6a8cbaa0ef475305f52
Author: Sven Grosen <svengrosen@gmail.com>
Date:   Thu Mar 12 08:11:05 2015 -0500

    add/update tests

commit 232749d26c3b70353b4571978d5b0c812f0e0bd5
Author: Sven Grosen <svengrosen@gmail.com>
Date:   Thu Mar 12 08:03:06 2015 -0500

    Seemingly got everything now bailing out appropriately

commit a864606edb4f7ccc545aa9da46f7c3e2d152e20f
Author: Sven Grosen <svengrosen@gmail.com>
Date:   Fri Mar 6 22:58:22 2015 -0600

    Updates from testing

commit 0a146be6a5e2ab665c391369bdbc56a1e5abfb4d
Author: Sven Grosen <svengrosen@gmail.com>
Date:   Fri Mar 6 21:55:05 2015 -0600

    Refactor to allow escaped brackets using regex

commit ca4eb38979ee76c86ca0968d7ef017d1cecf42d0
Author: Sven Grosen <svengrosen@gmail.com>
Date:   Wed Feb 25 20:54:23 2015 -0600

    Throttle recursive calls to parent method as they get expensive quickly

commit c40ca81d550e797fa902ac64fd13749c4208294a
Author: Sven Grosen <svengrosen@gmail.com>
Date:   Mon Feb 23 19:54:31 2015 -0600

    Add test cases for multiple property scenarios

commit b83a42cc6d03fceb71292a5e41ef93fec06d789d
Author: Sven Grosen <svengrosen@gmail.com>
Date:   Sat Feb 21 08:21:46 2015 -0600

    Fix new test case when unmatched ending bracket

commit 0a3c630159927defcf380155e3e08a114d617dad
Author: Sven Grosen <svengrosen@gmail.com>
Date:   Sat Feb 21 08:09:12 2015 -0600

    fix test cases broken but not noticed due to tests hanging on to old dll

commit 1ba542951d965fd4211ff49a0a7de4da02f8526e
Author: Sven Grosen <svengrosen@gmail.com>
Date:   Fri Feb 20 23:11:40 2015 -0600

    Updates from testing

commit 5debfc6a0a5d7c3fa7874efbdd8eb2e9a2c509f7
Author: Sven Grosen <svengrosen@gmail.com>
Date:   Wed Feb 18 20:30:42 2015 -0600

    Update code to better match existing, reword description of attribute

commit 8ceaeb7c4309a99a1ee7a0e4f9b0c11280f2bacd
Author: Sven Grosen <svengrosen@gmail.com>
Date:   Mon Feb 16 14:52:04 2015 -0600

    Now I think it is right, maybe...

commit 353bbfe9670551cb8744dc7dbba01ca94afd5071
Author: Sven Grosen <svengrosen@gmail.com>
Date:   Mon Feb 16 14:02:50 2015 -0600

    Get spacing right, at least for first tests

commit 3d100a9989449bbe698c3106a2faa8ba7cec82e4
Author: Sven Grosen <svengrosen@gmail.com>
Date:   Sun Feb 15 22:05:52 2015 -0600

    formatting of comments and get space right at beginning of output text

commit 33c1d80eb11dc8d03dd7945c15872a0cb7cf42bb
Author: Sven Grosen <svengrosen@gmail.com>
Date:   Sun Feb 15 21:49:41 2015 -0600

    switch to match statement

commit 05b014087ff116f04f78f4ac3d4ab811244ce8b7
Author: Sven Grosen <svengrosen@gmail.com>
Date:   Sun Feb 15 21:31:12 2015 -0600

    first stab, spacing is wonky
@dsyme

This comment has been minimized.

Show comment
Hide comment
@dsyme

dsyme Mar 22, 2015

Contributor

It's possible this fix from F# 4.0 will fix this: Microsoft/visualfsharp@3ed163f

If so, we should cherrypick it to "master" in this repo (it will also appear in the "fsharp4" branch as a result of this integration: #397 )

Contributor

dsyme commented Mar 22, 2015

It's possible this fix from F# 4.0 will fix this: Microsoft/visualfsharp@3ed163f

If so, we should cherrypick it to "master" in this repo (it will also appear in the "fsharp4" branch as a result of this integration: #397 )

@dsyme

This comment has been minimized.

Show comment
Hide comment
@dsyme

dsyme Mar 30, 2017

Contributor

Closing in favour of #307

Contributor

dsyme commented Mar 30, 2017

Closing in favour of #307

@dsyme dsyme closed this Mar 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment