Added configuration for customising fsi colors #134

Merged
merged 9 commits into from Apr 8, 2013

Conversation

Projects
None yet
4 participants
Contributor

kjnilsson commented Apr 2, 2013

You can also match the fsi theme to the current color scheme selected.

Contributor

kjnilsson commented Apr 2, 2013

Just found an issue with this so I'd hold on until I have updated it.

Contributor

knocte commented Apr 2, 2013

Nitpick: seems like there are unwanted changes in some .fsproj files (changing backslashes to slashes). This is probably a bug in the FSharpBinding BTW.

Contributor

knocte commented Apr 2, 2013

Actually, it's on .csproj files, so the bug is in MonoDevelop. What version of MD/XS are you using?

Contributor

kjnilsson commented Apr 2, 2013

Hi - you're right - I was bit eager on de-windowsifying that csproj file after it had changed all the slashes in the references to backslashes. I am using XS 4.0.3. Added commit to correct this.

Contributor

knocte commented Apr 2, 2013

Cool. Ok if you're using XS 4.0.3 then it's definitely a bug not fixed yet in upstream, can you file a bug in http://bugzilla.xamarin.com/ ? MonoDevelop should never change backslashes to slashes even in Unix, because backslashes is the MSBuild standard and it should follow it, and interpret backslashes well in all platforms.

Contributor

knocte commented Apr 2, 2013

Oh, BTW, in your last commit you only corrected one occurrence of the problem, but there are more.

Contributor

knocte commented Apr 2, 2013

Oh scratch that, I only saw 1 of your 2 commits. What happens now is that there is a change in a .csproj which is just changing the order of a reference, which, ideally (again, nitpick) should not be included in the pull-request.

Contributor

kjnilsson commented Apr 2, 2013

Fixed. The reason the csproj file is a bit munged is that the gtk visual editor doesn't seem to work when using gtk references that are not in the gak. I had to remove and re-add the gtk references after edit but yes it should not have been in the pull request.

Contributor

kjnilsson commented Apr 2, 2013

Sorry i didn't make it clear - I changed the backslashes to slashes by mistake whilst tidying up the references that had been changed for slashes to backslashes by XS when I re-added them. Does that make sense? Is this a bug?

Contributor

knocte commented Apr 2, 2013

References should contain backslashes too, if you manually changed it to have slashes you should change it back.

Contributor

kjnilsson commented Apr 2, 2013

Ok will do but that is a change to what it was previously which is why I changed it back. Cheers.

Sent from my iPhone

On 2 Apr 2013, at 22:12, "Andres G. Aragoneses" notifications@github.com wrote:

References should contain backslashes too, if you manually changed it to have slashes you should change it back.


Reply to this email directly or view it on GitHub.

Contributor

knocte commented Apr 2, 2013

Oh, sorry then leave it like it is.

There is a bug in MonoDevelop if you opened the project with XS 4.0.3 and it changed the project file to put slashes instead of backslashes.

Contributor

kjnilsson commented Apr 2, 2013

Right ok. I thought it was done weird windows behaviour. Thanks for the help.

On 2 Apr 2013, at 22:23, "Andres G. Aragoneses" notifications@github.com wrote:

Oh, sorry then leave it like it is.

There is a bug in MonoDevelop if you opened the project with XS 4.0.3 and it changed the project file to put slashes instead of backslashes.


Reply to this email directly or view it on GitHub.

Contributor

kjnilsson commented Apr 3, 2013

Just tested this on OSX and it appears to work just fine.

Contributor

funnelweb commented Apr 7, 2013

@7sharp9 are you ok with merging this?

Member

7sharp9 commented Apr 7, 2013

To be honest I only quickly looked at the changes. If the superfluous commits have been removed then I think it looked ok. I've not tested it though.

On 7 Apr 2013, at 19:44, funnelweb notifications@github.com wrote:

@7sharp9 are you ok with merging this?


Reply to this email directly or view it on GitHub.

Contributor

kjnilsson commented Apr 8, 2013

yep I had to 'unmunge' the project files and didn't do a very good job of it initially. I have been running with this for a few days now (on windows and osx) and not experienced any issues myself. Now I mainly develop on OSX I hope to have a smoother GTK# experience.

Contributor

funnelweb commented Apr 8, 2013

ok, lets merge. However we will need to check that things work on Windows before pushing an update to the gallery

@funnelweb funnelweb added a commit that referenced this pull request Apr 8, 2013

@funnelweb funnelweb Merge pull request #134 from kjnilsson/master
Added configuration for customising fsi colors
f353e68

@funnelweb funnelweb merged commit f353e68 into fsharp:master Apr 8, 2013

Member

7sharp9 commented Apr 8, 2013

I might have some changes later in the week too. (Not for this but other issues.)

Contributor

kjnilsson commented Apr 8, 2013

Thanks. When I can I will pull these changes and give them post merge test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment