New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running compiler on project files containing FSX scripts #609

Closed
stishkin opened this Issue Sep 25, 2017 · 6 comments

Comments

Projects
None yet
4 participants
@stishkin

stishkin commented Sep 25, 2017

Allowing compilation step of a project file with FSX scripts to verify that scripts do not have any errors. Currently I have to ether run the script or open it in Visual Studio editor (or VSTS editor). If I have a big corpus of scripts, it would be great to run compiler over them to see which ones have errors and need fixing.

Pros and Cons

The advantage of making this adjustment to F# that it enables better scripting exeperience.

Extra information

Estimated cost (XS, S, M, L, XL, XXL): S

Affidavit (please submit!)

Please tick this by placing a cross in the box:

  • This is not a question (e.g. like one you might ask on stackoverflow) and I have searched stackoverflow for discussions of this issue
  • I have searched both open and closed suggestions on this site and believe this is not a duplicate
  • This is not something which has obviously "already been decided" in previous versions of F#. If you're questioning a fundamental design decision that has obviously already been taken (e.g. "Make F# untyped") then please don't submit it.

Please tick all that apply:

  • This is not a breaking change to the F# language design
  • I or my company would be willing to help implement and/or test this
@dsyme

This comment has been minimized.

Show comment
Hide comment
@dsyme

dsyme Sep 25, 2017

Collaborator

Why not just run fsc.exe on the scripts one by one? Why would we build that capability into the F# compiler when it can be done easily via a script?

Collaborator

dsyme commented Sep 25, 2017

Why not just run fsc.exe on the scripts one by one? Why would we build that capability into the F# compiler when it can be done easily via a script?

@realvictorprm

This comment has been minimized.

Show comment
Hide comment
@realvictorprm

realvictorprm Sep 25, 2017

Member

@dsyme I instead suggest to add this for editors as option instead of adding it to the compiler (which is already built in so far I know).

Member

realvictorprm commented Sep 25, 2017

@dsyme I instead suggest to add this for editors as option instead of adding it to the compiler (which is already built in so far I know).

@dsyme

This comment has been minimized.

Show comment
Hide comment
@dsyme

dsyme Sep 25, 2017

Collaborator

@realvictorprm I think you can just add an MSBuild task to do it. Or a few lines of Unix scripting?

Collaborator

dsyme commented Sep 25, 2017

@realvictorprm I think you can just add an MSBuild task to do it. Or a few lines of Unix scripting?

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Sep 25, 2017

@dsyme While I fully agree that fsc.exe is the correct solution here, I think there are some edge cases where a fully valid script doesn't actually compile with fsc.exe (because of compiler directives only valid in Scripting environments or different behaviors). So it is a "mostly works" solution at the moment.

matthid commented Sep 25, 2017

@dsyme While I fully agree that fsc.exe is the correct solution here, I think there are some edge cases where a fully valid script doesn't actually compile with fsc.exe (because of compiler directives only valid in Scripting environments or different behaviors). So it is a "mostly works" solution at the moment.

@realvictorprm

This comment has been minimized.

Show comment
Hide comment
@realvictorprm

realvictorprm Sep 26, 2017

Member

Is this considered as bug @matthid?
If so then we can fix it, if not I suggest to @stishkin to open a proposal for this.

Member

realvictorprm commented Sep 26, 2017

Is this considered as bug @matthid?
If so then we can fix it, if not I suggest to @stishkin to open a proposal for this.

@dsyme

This comment has been minimized.

Show comment
Hide comment
@dsyme

dsyme Nov 16, 2017

Collaborator

I'm closing this as it is a tooling issue. If there's some way to just improve dotnet build or new-style F# project files to handle this case nicely then we should just do it in the F# compiler repo.

Collaborator

dsyme commented Nov 16, 2017

I'm closing this as it is a tooling issue. If there's some way to just improve dotnet build or new-style F# project files to handle this case nicely then we should just do it in the F# compiler repo.

@dsyme dsyme closed this Nov 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment