New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow attributes for discriminated union case fields #684

Open
tastyeggs opened this Issue Aug 13, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@tastyeggs

tastyeggs commented Aug 13, 2018

Allow attributes for discriminated union case fields

I propose we allow the specification of attributes on case fields of discriminated unions.

Here's an example:

type A =
| ACase of [<SomeAttr>] SomeField
| BCase [<SomeOtherAttr>] SomeFieldName: SomeType

The existing way of approaching this problem in F# is none, if we want case fields to be decorated

Pros and Cons

The advantages of making this adjustment to F# are

  • It opens up more possibilities of what one can do with reflection using F# types
  • Since the union case fields are simply .NET properties, it helps with other libraries that expect attributes

The disadvantages of making this adjustment to F# are none

Extra information

Estimated cost (XS, S, M, L, XL, XXL): XS

Affidavit (please submit!)

Please tick this by placing a cross in the box:

  • This is not a question (e.g. like one you might ask on stackoverflow) and I have searched stackoverflow for discussions of this issue
  • I have searched both open and closed suggestions on this site and believe this is not a duplicate
  • This is not something which has obviously "already been decided" in previous versions of F#. If you're questioning a fundamental design decision that has obviously already been taken (e.g. "Make F# untyped") then please don't submit it.

Please tick all that apply:

  • This is not a breaking change to the F# language design
  • I or my company would be willing to help implement and/or test this
@zpodlovics

This comment has been minimized.

Show comment
Hide comment
@zpodlovics

zpodlovics Aug 19, 2018

Relate issue: "Performance: Please consider allowing more control over the layout / size / alignment of fields of records and discriminated unions (case + individual fields)" Microsoft/visualfsharp#5215

zpodlovics commented Aug 19, 2018

Relate issue: "Performance: Please consider allowing more control over the layout / size / alignment of fields of records and discriminated unions (case + individual fields)" Microsoft/visualfsharp#5215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment